fix(vision): overlay wheel zoomを安定化 - #23
Merged
Merged
Conversation
Closed
ssaattww
marked this pull request as ready for review
July 20, 2026 09:36
ssaattww
added a commit
that referenced
this pull request
Jul 20, 2026
## 背景 - merge 済み PR #23 の wheel zoom 変更を Issue #12 の意図に照らして独立レビューする必要があった ## 変更内容 - PR #23 の code review と submission review の証跡を reports に追加した - ISSUE-12-POSTMERGE-REVIEW の状態、Low hold、CI 証跡を tracking に同期した ## 検証 - merge commit d9ca3ee の GitHub Actions run 29732105393: 329 tests passed - git diff --cached --check - Markdown wording lint は repository に実行基盤がなく unsupported として report に記録
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Issue #12 のオーバーレイ表示で、左右分割表示と同じ wheel zoom / reset 契約を保証します。
field 上の wheel gesture をブラウザーの page scroll へ流さず、split / overlay のどちらでも field viewport の zoom 操作として完結させます。
変更内容
VisionFieldRenderContractTestsに split / overlay 共通の wheel zoom 回帰テストを追加VisionFieldCanvasの wheel event にpreventDefaultを追加VisionFieldOverlayCanvasの wheel event にpreventDefaultを追加OnFieldWheel、VisionFieldViewportState、Reset、projection / transform 契約は変更しないTDD
Red
21c6632test: overlay wheel zoom contractを追加.NET testsrun Issue #10 Vision画面に分割表示とオーバーレイを追加する #15 は、両 component に@onwheel:preventDefault="true"が無いため想定どおり失敗dotnet-test-failure-29731515675-1に TRX、vstest diagnostics、MSBuild binlog、stdout / stderr、環境情報、対象ソースを保存Green
e3c7b0cfix: overlay wheel gestureをcanvas内に閉じるcc87195fix: split wheel zoomも同じgesture契約へ揃える.NET testsrun Aspire対応 #18 成功レビュー
Fixes #12