Add Task::blocking helper#3389
Open
edwloef wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... and replace usages of
task::blockingandtask::try_blocking.The semantics of
task::blockingandtask::try_blockingweren't entirely clear without reading the function bodies themselves, since they provided the blocking closure with an async channel that you can onlytry_sendon. Most uses only send one item, which is fine since the channel has capacity 1, but sending multiple items can lead to encountering a full channel, which you can't do anything useful about in a blocking context. In the one case where that was necessary (devtools comet installation) silently dropping the message in such situations is probably okay though.Now, when it's just one item, we can just use the return value of that closure. When it's not, the user can move a sender into the closure and batch with the receiver, so they can choose whether to use an unbounded channel, a bounded channel with potential message loss, or a channel supporting both blocking
sendand asyncrecv(e.g.tokio,smol, ...).