Normalize event session descriptions - #9429
Draft
michaelchadwick wants to merge 8 commits into
Draft
Conversation
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
❌ Visual Diff Report — FAILED2024 images compared: 18 different · 2006 identical DetailsDifferences (18)
Download the results. |
michaelchadwick
changed the title
Contributor
Author
|
NTS: Try combining TruncateText but with the FadeText vertical checking. |
michaelchadwick
force-pushed
the
frontend-6656-dash-fade-long-event-text
branch
from
August 5, 2026 21:49
0950301 to
ce53fe3
Compare
michaelchadwick
changed the title
michaelchadwick
marked this pull request as ready for review
August 6, 2026 22:23
Member
|
stopfstedt
approved these changes
Aug 7, 2026
Member
|
Member
|
I know it's on me to merge this PR but I'm not quite feeling it ... yet. |
Member
|
from PR build ... 
from Netlify ... 
|
…, and truncate it
…tch WaaG versions
…yle of Session->Description view
…dded it to both WaaG and Single Event components
… be in totality in this context
michaelchadwick
force-pushed
the
frontend-6656-dash-fade-long-event-text
branch
from
August 12, 2026 16:33
a795c0c to
65384ec
Compare
michaelchadwick
changed the title
michaelchadwick
marked this pull request as draft
August 27, 2026 18:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ilios/ilios#6656
After much work trying to get
TruncateText's "character count" algo to work more likeFadeText's "vertical space" algo, I gave up as I was essentially turning one component into the other for no reason.In the end, just putting
TruncateTexton session descriptions when shown on the WaaG and/or Single Event routes feels like enough. If it's overly tall, it still won't truncate unless the character count is long enough, which feels like an edge cases most of the time.This also squares up the presentation of session descriptions across WaaG, Single Event, Session, and editing Session, as they were not normalized (mainly in how they displayed lists).
Here's an example of various description "lengths" on the dashboard and how they'd now be handled.
The preview, logged in as dev, also currently has a course with a session and a wacky description to check all this again.