Use focus Modifier on Login Form - #9484
Open
jrjohnson wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
✅ Visual Diff Approved❌ Visual Diff Report — FAILED2024 images compared: 3 different · 2021 identical DetailsDifferences (3)
Download the results. |
jrjohnson
force-pushed
the
focus-screenshot-race
branch
3 times, most recently
from
August 26, 2026 17:17
b229e05 to
a97b968
Compare
Might be more accessible, but I'm primarily trying to resolve a race condition in our screenshots.
We get race conditions on the input focus in screenshots in this test, need to explicitly wait for the focus so we take a useful picture.
jrjohnson
force-pushed
the
focus-screenshot-race
branch
from
August 27, 2026 23:42
a97b968 to
aa4a38e
Compare
jrjohnson
added
the
approve visual diff
jrjohnson
marked this pull request as ready for review
August 28, 2026 01:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might be more accessible, but I'm primarily trying to resolve a race condition in our screenshots.