Get Version Ourselves - #9487
Open
jrjohnson wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jrjohnson
force-pushed
the
local-app-version
branch
from
August 26, 2026 05:20
923b0a8 to
69c6ca4
Compare
Contributor
✅ Visual Diff Approved❌ Visual Diff Report — FAILED2024 images compared: 10 different · 2014 identical DetailsDifferences (10)
Download the results. |
We're getting this helper from ember-cli-version and the way it gets bundled into our app isn't great. Let's ditch the dependency and just extract the version in package.json and push it into the config.
jrjohnson
force-pushed
the
local-app-version
branch
from
August 27, 2026 23:43
69c6ca4 to
e0d3b3e
Compare
jrjohnson
marked this pull request as ready for review
August 28, 2026 01:16
jrjohnson
added
the
approve visual diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're getting this helper from ember-cli-version and the way it gets bundled into our app isn't great. Let's ditch the dependency and just extract the version from the config directly.