Skip to content

Set Params to Defaults - #9488

Open
jrjohnson wants to merge 1 commit into
ilios:masterfrom
jrjohnson:drop-ember-import
Open

Set Params to Defaults#9488
jrjohnson wants to merge 1 commit into
ilios:masterfrom
jrjohnson:drop-ember-import

Conversation

@jrjohnson

Copy link
Copy Markdown
Member

Instead of importing this from Ember we can just set these to false, which is their default. This export is no longer provided and using it is SUPER deprecated.

@netlify

netlify Bot commented Aug 26, 2026

Copy link
Copy Markdown

Deploy Preview for ilios-frontend ready!

Name Link
🔨 Latest commit 9f6b92a
🔍 Latest deploy log https://app.netlify.com/projects/ilios-frontend/deploys/6a90cb943ba9af000703d734
😎 Deploy Preview https://deploy-preview-9488--ilios-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

✅ Visual Diff Approved

❌ Visual Diff Report — FAILED

2024 images compared: 7 different · 2017 identical

Details

Differences (7)

File Diff % Notes
desktop-Acceptance _ Auth Errors_request for preferences unauthorized__light.png 0.24%
desktop-Acceptance _ Course - Session List_expand all sessions_expanded_light.png 0.00%
desktop-Acceptance _ Course - Session List_expand all sessions_not expanded_light.png 0.07%
phone-Acceptance _ Auth Errors_request for preferences unauthorized__dark.png 0.62%
tablet-Acceptance _ Auth Errors_request for preferences unauthorized__dark.png 0.41%
tablet-Acceptance _ Course - Session List_expand all sessions_not expanded_dark.png 0.09%
tablet-Acceptance _ Course - Session List_expand all sessions_not expanded_light.png 0.10%

Download the results.

Instead of importing this from Ember we can just set these to false,
which is their default. This export is no longer provided and using it
is SUPER deprecated.
@jrjohnson jrjohnson added the approve visual diff Manually Approve the Results of a Visual Diff Run label Aug 28, 2026
@jrjohnson
jrjohnson marked this pull request as ready for review August 28, 2026 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approve visual diff Manually Approve the Results of a Visual Diff Run

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant