Remove Visual Diff Approval for New Code - #9494
Open
jrjohnson wants to merge 1 commit into
Open
Conversation
When a PR gets updated this task will run to remove the `approve visual diff` label. This will then require a re-check of screenshots if there are any problems and avoid merging (or automerging) the PR if there are new issues that pop up.
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
✅ Visual Diff Approved❌ Visual Diff Report — FAILED2064 images compared: 2 different · 2062 identical DetailsDifferences (2)
Download the results. |
jrjohnson
added
the
approve visual diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a PR gets updated this task will run to remove the
approve visual difflabel. This will then require a re-check of screenshots if there are any problems and avoid merging (or automerging) the PR if there are new issues that pop up.I had to use the
pull_request_targettype here to support forks so this won't run until after it is merged.