Skip to content

Weapon-related redraw improvements and bug fixes - #1630

Merged
ergoxiv merged 11 commits into
imchillin:masterfrom
ergoxiv:hotfix/weapon-redraw-improvements-and-fixes
Aug 16, 2026
Merged

ergoxiv merged 11 commits into
imchillin:masterfrom
ergoxiv:hotfix/weapon-redraw-improvements-and-fixes

Conversation

@ergoxiv

@ergoxiv ergoxiv commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

Changelog:

  • Added a checkbox toggle feature that links the dye channels of the main hand and off-hand. It is enabled by default.
    • Explanation: This is done as the game only checks the off-hand dye channels on some items (e.g. monk fists). Since most users are unlikely to want to switch the dyes independently, the checkbox is toggled on by default.
  • Resolved an issue, which caused actors to become and stay invisible after a redraw when swapping between one-handed and two-handed weapon types that differ from what was equipped prior to entering GPose.
  • Fixed an issue where certain weapons (e.g., monk fists) failed to update their model assets when switched under specific conditions.
  • Resolved a bug where updating equipment prevented weapon models (e.g. monk fists) from re-rendering during actor redraws.
  • Weapon visibilitty state is now preserved across actor redraws.
    • Explanation: Previously, weapon visibility would reset to whatever sheathe state the actor had before entering GPose.
  • Refactored the weapon visibility toggle feature to use the weapon's object flags instead of modifying transform scale.
    • Explanation: This replaces the old hacky solution, which mimicked visibility toggling by updating the weapon's model scale to 0 and 1.
  • Fixed an issue with model ID handling for weapons which prevented some off-hand items from being recognized as weapons.
  • Resolved an issue with off-hand weapons not importing correctly on some NPC appearances.
  • Fixed a localization issue with the model set, base, and variant field tooltips in the item view component.
  • Removed previous workaround that set the main hand to "Emperor's New Fists" on weapon change to model id 0 (i.e., no item).

@ergoxiv ergoxiv self-assigned this Aug 15, 2026
@ergoxiv ergoxiv added Appearance Refers to application functionality related to actor appearance (incl. equipment, ornaments, etc.). Interoperability Refers to functionality related to the interoperability between the application and the game. Actor Refers to actor-related functionality that encompases anything that affects the game character. labels Aug 15, 2026
@ergoxiv
ergoxiv merged commit 47f6895 into imchillin:master Aug 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Actor Refers to actor-related functionality that encompases anything that affects the game character. Appearance Refers to application functionality related to actor appearance (incl. equipment, ornaments, etc.). Interoperability Refers to functionality related to the interoperability between the application and the game.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant