feat(logging): add tracing instrumentation and refine log messages - #754
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates identity-wallet’s observability by adding tracing::instrument spans to many async reducers/helpers and refining log messages/levels to reduce noise and avoid logging verbose payloads at info.
Changes:
- Add
#[tracing::instrument(skip_all, err)]to reducers and several helper functions. - Demote verbose/value-heavy
info!logs todebug!and replace “function name” logs with intent/parameter-focused messages. - Update the
oid4vcgit revision and expand Tauri log filtering to includeoid4vc*crates.
Reviewed changes
Copilot reviewed 53 out of 54 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| unime/src-tauri/src/lib.rs | Adds debug log filters for oid4vc* crates in Tauri logging. |
| identity-wallet/src/subject.rs | Demotes resolver init logs to debug. |
| identity-wallet/src/stronghold.rs | Demotes key-generation / snapshot logs to debug. |
| identity-wallet/src/state/verified_data/reducers/mod.rs | Adds tracing + refines email verification flow logs. |
| identity-wallet/src/state/user_journey/reducers/cancel_user_journey.rs | Adds tracing and debug log for cancellation. |
| identity-wallet/src/state/trust_list/reducers/toggle_entry.rs | Adds tracing instrumentation. |
| identity-wallet/src/state/trust_list/reducers/edit_trust_list.rs | Adds tracing instrumentation. |
| identity-wallet/src/state/trust_list/reducers/edit_entry.rs | Adds tracing instrumentation. |
| identity-wallet/src/state/trust_list/reducers/delete_trust_list.rs | Adds tracing instrumentation. |
| identity-wallet/src/state/trust_list/reducers/delete_entry.rs | Adds tracing instrumentation. |
| identity-wallet/src/state/trust_list/reducers/add_trust_list.rs | Adds tracing instrumentation. |
| identity-wallet/src/state/trust_list/reducers/add_entry.rs | Adds tracing instrumentation. |
| identity-wallet/src/state/search/reducers/search_query.rs | Adds tracing + debug summary of match counts. |
| identity-wallet/src/state/search/reducers/delete_recent_search.rs | Adds tracing + debug log for deletion. |
| identity-wallet/src/state/search/reducers/add_recent_search.rs | Adds tracing + debug log for insertion. |
| identity-wallet/src/state/qr_code/reducers/read_credential_offer.rs | Adds tracing + shifts verbose offer/metadata logs to debug. |
| identity-wallet/src/state/qr_code/reducers/read_authorization_request.rs | Adds tracing + refines request metadata logs and reduces verbosity. |
| identity-wallet/src/state/profile_settings/reducers/update_sorting_preference.rs | Adds tracing instrumentation to sorting reducers. |
| identity-wallet/src/state/profile_settings/reducers/update_profile_settings.rs | Adds tracing + debug log for profile settings updates. |
| identity-wallet/src/state/profile_settings/reducers/set_locale.rs | Adds tracing instrumentation to locale reducer. |
| identity-wallet/src/state/profile_settings/reducers/enable_biometrics.rs | Adds tracing instrumentation to biometrics reducer. |
| identity-wallet/src/state/profile_settings/reducers/create_new.rs | Adds tracing + refines create-identity lifecycle logging. |
| identity-wallet/src/state/did/validate_linked_verifiable_presentations.rs | Demotes high-volume DID/presentation logs to debug. |
| identity-wallet/src/state/did/validate_domain_linkage.rs | Demotes domain linkage logs to debug. |
| identity-wallet/src/state/did/reducers/preferred_method.rs | Adds tracing instrumentation. |
| identity-wallet/src/state/did/reducers/preferred_keytype.rs | Adds tracing instrumentation. |
| identity-wallet/src/state/dev_mode/reducers/toggle_dev_mode.rs | Adds tracing instrumentation. |
| identity-wallet/src/state/dev_mode/reducers/show_setting.rs | Adds tracing instrumentation. |
| identity-wallet/src/state/dev_mode/reducers/reducers.rs | Adds tracing instrumentation to unlock reducer. |
| identity-wallet/src/state/dev_mode/reducers/load_dev_profile.rs | Adds tracing + improves dev-profile log context. |
| identity-wallet/src/state/dev_mode/reducers/ferris_static_profile.rs | Adds tracing instrumentation. |
| identity-wallet/src/state/dev_mode/reducers/dragon_dynamic_profile.rs | Adds tracing instrumentation. |
| identity-wallet/src/state/dev_mode/reducers/clear_debug_log.rs | Adds tracing instrumentation. |
| identity-wallet/src/state/credentials/reducers/update_credential_metadata.rs | Adds tracing + demotes before/after metadata logs to debug. |
| identity-wallet/src/state/credentials/reducers/share_to_linkedin.rs | Adds tracing + info log for share intent. |
| identity-wallet/src/state/credentials/reducers/send_token_request.rs | Adds tracing + refines token-request intent logging; demotes verbose logs. |
| identity-wallet/src/state/credentials/reducers/send_interactive_authorization_request_follow_up.rs | Adds tracing + intent log with credential count. |
| identity-wallet/src/state/credentials/reducers/send_credential_request.rs | Adds tracing + refines offer-handling logs; reduces verbosity. |
| identity-wallet/src/state/credentials/reducers/self_issue_credential.rs | Adds tracing + intent logs for self-issuance. |
| identity-wallet/src/state/credentials/reducers/refresh_credential_status.rs | Adds tracing instrumentation to status refresh helpers. |
| identity-wallet/src/state/credentials/reducers/refresh_all_credential_statuses.rs | Adds tracing instrumentation. |
| identity-wallet/src/state/credentials/reducers/handle_oid4vp_authorization_request.rs | Adds tracing + improves error context/verbosity in OID4VP flow. |
| identity-wallet/src/state/credentials/reducers/delete_credential.rs | Adds tracing instrumentation. |
| identity-wallet/src/state/connections/reducers/handle_siopv2_authorization_request.rs | Adds tracing + refines SIOPv2 response lifecycle logs. |
| identity-wallet/src/state/common/reducers/unlock_storage.rs | Adds tracing + improves unlock lifecycle logs and counts. |
| identity-wallet/src/state/common/reducers/reset_state.rs | Adds tracing + info log for state reset. |
| identity-wallet/src/state/common/reducers/get_state.rs | Adds tracing instrumentation. |
| identity-wallet/src/state/common/reducers/check_password.rs | Adds tracing + logs password verification outcomes. |
| identity-wallet/src/state/common/reducers/cancel_user_flow.rs | Adds tracing + debug log for flow cancellation. |
| identity-wallet/src/persistence.rs | Demotes storage-path logs to debug. |
| identity-wallet/src/command.rs | Adds reduce duration timing and refines timeout/error logs. |
| identity-wallet/Cargo.toml | Adds direct tracing dependency for instrumentation usage. |
| Cargo.toml | Updates oid4vc git rev (includes a temporary marker comment). |
| Cargo.lock | Updates lockfile for oid4vc rev and tracing deps. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
daniel-mader
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
This PR improves the logging and observability strategy across
identity-wallet:tracing::instrumentAnnotations: Added#[tracing::instrument(skip_all, err)]across all reducer and key I/O helper functions. This automatically captures spans and emits errors atERRORlevel viatracing's defaultlogbridge when operations fail.info!todebug!Demotions:info!todebug!to prevent log flooding in logcat/console and avoid logging potentially sensitive payload fields at standard levels.info!is reserved for high-level lifecycle milestones (e.g. initiating flows, successful status checks, profile resets), maintaining a high signal-to-noise ratio.info!("send_token_request")) with contextual logs capturing key parameters and intent.openid4vcdependency: Updatedoid4vcgit rev to incorporate latest tracing and log improvements from openid4vc#134.Example of improved log messages:
Old:
New:
Links to any relevant issues
How the change has been tested
cargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningscargo test --workspace(116 unit tests, 29 integration tests, 1 doc test passing)tauri-plugin-logwith Androidadb logcatand desktop targetsDefinition of Done checklist