Skip to content

馃敟 Remove dags moved to prd repo and only deploy on merge into main - #50

Merged
chris-s-friedman merged 2 commits into
mainfrom
feature/cf/remove_prd_dags
Aug 3, 2026
Merged

馃敟 Remove dags moved to prd repo and only deploy on merge into main#50
chris-s-friedman merged 2 commits into
mainfrom
feature/cf/remove_prd_dags

Conversation

@chris-s-friedman

@chris-s-friedman chris-s-friedman commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

remove dags moved to prd repo

these dags were moved to the prd repo in https://github.com/include-dcc/include-kf-dbt-harmonization/pull/9. This is so that we don't have multiple copies of the dags in airflow

Also changes deploy of dags to only happen on merge into main and not on push within pull request. This resolves an issue were pushing to a pull request branch overwrites contents in s3 on other branches.

Closes (issue identifier)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality
    to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details for
your test configuration

  • Test A
  • Test B

Test Configuration:

  • Environment:
  • Test files:

Checklist

Please check all of the items below before merging this pull request. If an
item in the list below does not need to be completed, please indicate the
reason why.

  • I ensured that all tables have proper source and ref definitions
  • I Defined {{ config(schema=[schema name], tags = [list, of, tags]) }} at
    the start of each script
  • I have performed a self-review of my own code
  • I have checked my code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature
    works
  • My code follows the style guidelines of this project
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have committed any related changes to the PR
  • Run sqlfluff fix on tables that are created or modified in this PR.

@chris-s-friedman chris-s-friedman changed the title 馃敟 Remove dags moved to prd repo 馃敟 Remove dags moved to prd repo and only deploy on merge into main Jul 31, 2026
@chris-s-friedman
chris-s-friedman requested a review from awarkow July 31, 2026 15:54

@awarkow awarkow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chris-s-friedman

Copy link
Copy Markdown
Collaborator Author

note that I'm waiting to merge until after I merge https://github.com/include-dcc/include-kf-dbt-harmonization/pull/9

@chris-s-friedman
chris-s-friedman merged commit 3d300d4 into main Aug 3, 2026
@chris-s-friedman
chris-s-friedman deleted the feature/cf/remove_prd_dags branch August 3, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants