馃敟 Remove dags moved to prd repo and only deploy on merge into main - #50
Merged
Conversation
these dags were moved to the prd repo in include-dcc/include-kf-dbt-harmonization#9
Collaborator
Author
|
note that I'm waiting to merge until after I merge https://github.com/include-dcc/include-kf-dbt-harmonization/pull/9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove dags moved to prd repo
these dags were moved to the prd repo in https://github.com/include-dcc/include-kf-dbt-harmonization/pull/9. This is so that we don't have multiple copies of the dags in airflow
Also changes deploy of dags to only happen on merge into main and not on push within pull request. This resolves an issue were pushing to a pull request branch overwrites contents in s3 on other branches.
Closes (issue identifier)
Type of change
Please delete options that are not relevant.
to not work as expected)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details for
your test configuration
Test Configuration:
Checklist
Please check all of the items below before merging this pull request. If an
item in the list below does not need to be completed, please indicate the
reason why.
the start of each script
works
sqlfluff fixon tables that are created or modified in this PR.