feat(apollo): SJIP-1576 memoize apollo client to avoid recreating it on each render - #1020
Merged
Conversation
lflangis
previously approved these changes
Jun 10, 2026
✅ Deploy Preview for include-qa ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
AltefrohneGaelle
force-pushed
the
feat/sjip-1576
branch
from
June 11, 2026 21:51
6bbc13b to
6936d56
Compare
lflangis
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(apollo): memoize apollo client to avoid recreating it on each render
SJIP-1576
Description
The
ApolloClientwas being recreated on every render of theProvider, which alsoreset the
InMemoryCacheeach time. This PR memoizes the client creation withuseMemo,so it is only recreated when the
backendchanges.Changes
ApolloClientinstantiation in auseMemoAcceptance Criterias
Screenshot or Video
Before
After