Add Alpaca protocol drivers for telescope, focuser, and filter wheel#2338
Open
gordtulloch wants to merge 3 commits intoindilib:masterfrom
Open
Add Alpaca protocol drivers for telescope, focuser, and filter wheel#2338gordtulloch wants to merge 3 commits intoindilib:masterfrom
gordtulloch wants to merge 3 commits intoindilib:masterfrom
Conversation
gordtulloch
commented
Feb 17, 2026
gordtulloch
commented
- Add indi_alpaca_telescope driver with full mount control (goto, sync, park, tracking)
- Add indi_alpaca_focuser driver with absolute positioning and temperature monitoring
- Add indi_alpaca_filterwheel driver with focus offset support
- Update drivers.xml to register new Alpaca devices
- All drivers implement ASCOM Alpaca REST API specification
- Supports network-based device discovery and control
- Add indi_alpaca_telescope driver with full mount control (goto, sync, park, tracking) - Add indi_alpaca_focuser driver with absolute positioning and temperature monitoring - Add indi_alpaca_filterwheel driver with focus offset support - Update drivers.xml to register new Alpaca devices - All drivers implement ASCOM Alpaca REST API specification - Supports network-based device discovery and control
knro
reviewed
Feb 18, 2026
Comment on lines
+58
to
+67
| ITextVectorProperty ServerAddressTP; | ||
| IText ServerAddressT[2] {}; | ||
|
|
||
| // Device info properties | ||
| ITextVectorProperty DeviceInfoTP; | ||
| IText DeviceInfoT[4] {}; | ||
|
|
||
| // Filter properties | ||
| INumberVectorProperty FocusOffsetsNP; | ||
| INumber FocusOffsetsN[3] {}; |
Contributor
There was a problem hiding this comment.
Please only use modern INDI properties. i.e. INDI::PropertyText, INDI::PropertyNumber
knro
reviewed
Feb 18, 2026
Comment on lines
+61
to
+66
| ITextVectorProperty DeviceInfoTP; | ||
| IText DeviceInfoT[4] {}; | ||
|
|
||
| // Temperature property | ||
| INumberVectorProperty TemperatureNP; | ||
| INumber TemperatureN[1] {}; |
Contributor
There was a problem hiding this comment.
Please use only INDI modern property. e.g. INDI::PropertyText, INDI::PropertyNumber
knro
reviewed
Feb 18, 2026
Comment on lines
-10
to
-12
| <device label="Shelyak Usis" manufacturer="Shelyak"> | ||
| <driver name="Shelyak Usis">shelyak_usis</driver> | ||
| <version>1.2</version> |
Author
There was a problem hiding this comment.
This was an error, looked like a duplicate
Contributor
|
@gordtulloch Any update on the requested changes? |
Author
|
Back from holidays will work on it this week |
knro
reviewed
Mar 1, 2026
Comment on lines
+49
to
+51
| // Load saved configuration | ||
| defineProperty(ServerAddressTP); | ||
| loadConfig(true, "SERVER_ADDRESS"); |
Contributor
There was a problem hiding this comment.
No need for this. Simple add this after ServerAddressTP.fill(....)
ServerAddressTP.load();
knro
reviewed
Mar 1, 2026
Comment on lines
+56
to
+54
| if (!ServerAddressTP["HOST"].text.empty()) | ||
| if (ServerAddressTP[HOST_INDEX].text != nullptr && strlen(ServerAddressTP[HOST_INDEX].text) > 0) |
Contributor
There was a problem hiding this comment.
Actually, the empty check was indeed correct, why was it changed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.