Open
Conversation
Owner
|
Transplanted here for CI: https://gitlab.tiker.net/inducer/pycuda/merge_requests/11 |
Owner
|
Author
|
Owner
Ideally, I'd like for the whole file to be identical, so that for each change I can just drop a pull request into each repo with the same file, wait for CI to pass, and move on. I don't know if that's feasible though. If not, I could be OK with the identical bits (maybe the CL/CUDA source and a base class) living in a seperate file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tried to keep the kernel source code similar to the scan kernel in
pyopenclusingpycuda._cluda. I am listing out the differences between the two:RESTRICTmacro to_cluda(will make a corresponding PR topyopencl)is_gpuvariable and the extra code that came along with it for the CPUApart from this I've added some helper functions in
pycuda.tools, added tests forint64dtype and a test for segmented scans that are exactly similar to those inpyopencland updated the documentation.