Repository navigation
Add alert bridge component - #2
Merged
Merged
Conversation
Native counterpart of the web side's `alert` component: presents an AlertDialog from the `show` message and replies to it only when the confirming button is tapped. Dismissing — the button, a tap outside, or the back press — sends nothing, and the web side reads that silence as "not confirmed". Android has no destructive button style, so `destructive` tints the positive button with the theme's error colour instead. The tint is applied after show() because the buttons do not exist until then. Copied from the hotwire-bridge-components registry, which follows joemasilotti/bridge-components (MIT).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native half of the
alertbridge component, copied from the hotwire-bridge-components registry.Presents an
AlertDialogfrom the web side'sshowmessage and replies to that message only when the confirming button is tapped. Every other way out — the dismiss button, a tap outside, the back press — sends nothing back, and the web side reads that silence as "not confirmed".Android has no destructive button style, so
destructivetints the positive button with the theme'scolorErrorinstead. The tint is applied aftershow(), since the dialog's buttons do not exist before that; the colour is resolved throughresourceIdwhen the theme hands back a reference rather than a literal.Verified
Built and run on an emulator (Pixel, API 36) against the deployed demo. Both paths behave:
Keepleaves the page untouched,Deletereports back and the page updates. The error tint resolves — the confirm button draws red. Recording is on the docs PR.