chore: remove support link references #7112

mnaqvi08 · 2025-12-08T20:25:10Z

Addresses https://github.com/influxdata/EAR/issues/6468.

Follow-on branch to #7106 to trigger a new CI run to pull updates to monitor-ci-tests.

Checklist

Authors and Reviewer(s), please verify the following:

A PR description, regardless of the triviality of this change, that communicates the value of this PR
Well-formatted conventional commit messages that provide context into the change
Documentation updated or issue created (provide link to issue/PR)
Signed CLA (if not already signed)
Feature flagged, if applicable

…Form

wdoconnell

Nice work, and thanks for tackling this.

I left more detailed comments as a guide, but in general, the main changes I would make here are:

Omit the hardcoded hrefs to an empty ( # ) in the <a> elements, and update the e2e test to assert on the onClick handler behavior instead (that it opens the modal).
Change the "Submit" buttons to be more reflective of what they do, which is just to open a modal to create a request. "Create Request" seems appropriate.
I would see if we can test the updated sfdc API requests locally to ensure the data populates properly. (Let me know if helpful to pair on this.)

wdoconnell · 2025-12-09T16:22:08Z

src/cloud/components/SeriesCardinalityIncreaseForm.tsx

+      showOverlay(
+        'contact-support',
+        {
+          subject: `[Org: ${orgName}] [Org Id: ${orgID}] Request Series Cardinality Limit Increase`,


wdoconnell · 2025-12-09T16:26:00Z

src/cloud/components/SeriesCardinalityIncreaseForm.tsx

        size={ComponentSize.Medium}
        color={ComponentColor.Primary}
        className="rate-alert--request-increase-button"
        text="Submit Request"


The handleSubmit function no longer submits the form but opens a popup. Could we change the text to suit the fact that this button just opens the "Contact Support" menu with the appropriate props rather than submitting the request?

How about "Create Request."

Here's what this looks like now:

wdoconnell · 2025-12-09T16:30:23Z

src/cloud/components/WriteLimitOverlay.tsx

          size={ComponentSize.Medium}
          color={ComponentColor.Primary}
          className="rate-alert--request-increase-button"
          text="Submit Request"


Same comment here re: "Submit Request" since this just opens an overlay. I think "Create Request" may be better since it just opens a modal to prepare the contact-support request, and that modal has its own Submit button.

wdoconnell · 2025-12-09T16:30:37Z

src/cloud/constants/index.ts


 export const RATE_LIMIT_ERROR_TEXT =
-  'Oops. It looks like you have exceeded the query limits allowed as part of your plan. If you would like to increase your query limits, reach out at support.influxdata.com.'
+  'Oops. It looks like you have exceeded the query limits allowed as part of your plan. If you would like to increase your query limits, please use the Contact Support option in the Help menu.'


wdoconnell · 2025-12-09T16:35:01Z

src/identity/components/OrganizationListTab/OrganizationCard.tsx

+  const tooltipContent = (
+    <p>
+      Organizations can be reactivated within 7 days of deletion. Please{' '}
+      <a href="#" onClick={handleContactSupport}>


The current solution in this PR changes the application code to 'fix' a test, which should not be done -- we should update the e2e test to expect behaviors consistent with the way the app behaves.

The app now results in opening the contact support modal on click. So the e2e test, instead of looking for an href tag with an empty internal anchor ( # ), should expect that, when this element is clicked, the Contact Support overlay opens.

You probably don't need to supply the href attribute at all (unless the linter is requiring it). Per MDN, the href element is optional:

Content within each should indicate the link's destination. If the href attribute is present, pressing the enter key while focused on the element will activate it.

Using a <Link> Component could also be appropriate here.

wdoconnell · 2025-12-09T16:42:28Z

src/shared/components/NotFound.tsx

+                  <span>
+                    The webpage you were trying to reach may have been removed
+                    or your access to this page may have expired. Please{' '}
+                    <a href="#" onClick={handleContactSupport}>


Same comment here: I think if we use an actual Link element with can avoid setting the href to '#'.

wdoconnell · 2025-12-09T16:42:55Z

src/support/components/ConfirmationOverlay.tsx

-            support.influxdata.com{' '}
-          </SafeBlankLink>
+          For more resources, you can{' '}
+          <a href="#" onClick={handleContactSupport}>


Same comment re: not hardcoding '#' elements

wdoconnell · 2025-12-09T16:43:18Z

src/support/components/ContactSupportOverlay.tsx

-    '4 - Request',
-  ]
+  const isContractOrPAYG =
+    accountType === 'contract' || accountType === 'pay_as_you_go'


wdoconnell · 2025-12-09T16:44:43Z

src/support/components/PaidSupportForm.tsx

+          testID="contact-support-subject-input"
+        />
+      </Form.Element>
+      <Form.Element label="Severity" required={true} labelAddOn={severityTip}>


Spacing on this looks odd, might want to run prettier on this.

wdoconnell · 2025-12-09T17:34:54Z

cypress/e2e/cloud/org-list.test.ts

-      cy.get('a')
-        .contains('https://support.influxdata.com/s/login')
-        .should('have.attr', 'href', 'https://support.influxdata.com/s/login')
+      cy.get('a').contains('contact support').should('have.attr', 'href', '#')


See later comments -- We should update this test to check the onClick behavior, not for the presence of the href attribute.

mnaqvi08 · 2025-12-11T20:15:47Z

cypress/e2e/cloud/org-list.test.ts

-      cy.get('a')
-        .contains('https://support.influxdata.com/s/login')
-        .should('have.attr', 'href', 'https://support.influxdata.com/s/login')
+      cy.get('button').contains('contact support').should('exist')


Now checks that the tooltip contains a element with the text "contact support".

mnaqvi08 · 2025-12-11T20:18:15Z

@wdoconnell I opted to use <button> instead of Link since these trigger modals, not navigation. As I understand this is semantically more appropriate for actions. Happy to refactor to Link if you prefer.

mnaqvi08 added 6 commits December 4, 2025 08:26

fix: expand Contact Support access to paid customers

18748e7

fix(ui): remove direct Salesforce link from SeriesCardinalityIncrease…

fd73da8

…Form

chore: remove remaining support link references

a86b66a

feat: trigger modal on support options

7bec878

chore: fix lint errors

3c9857b

chore: address feedback

258b7ab

mnaqvi08 requested review from a team as code owners December 8, 2025 20:25

mnaqvi08 mentioned this pull request Dec 8, 2025

chore: remove support link references #7106

Closed

5 tasks

mnaqvi08 requested a review from wdoconnell December 8, 2025 20:26

test: remove link check

10886b2

wdoconnell reviewed Dec 9, 2025

View reviewed changes

chore: remove hardcoded links

783dfc9

mnaqvi08 commented Dec 11, 2025

View reviewed changes

chore: remove support link references #7112

Are you sure you want to change the base?

chore: remove support link references #7112

Uh oh!

Conversation

mnaqvi08 commented Dec 8, 2025

Checklist

Uh oh!

wdoconnell left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mnaqvi08 commented Dec 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants