chore: Add insightly-1 rollup chain to registry#819
Open
anjayrion157-hash wants to merge 2 commits into
Open
Conversation
- Chain ID: insightly-1 - Type: Social Prediction Markets (DeFi) - Status: Testnet - Repository: https://github.com/RionAsari/Initiate - Configuration: Chain metadata, endpoints, and assets included
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (4)
WalkthroughAdds a new "Insightly" rollup package (chain ID: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
🧹 Nitpick comments (2)
rollups/insightly-1/chain.json (1)
16-20: Consider differentiating gas price levels.All gas price levels (
fixed_min_gas_price,low_gas_price,avg_gas_price,high_gas_price) are set to the same value of0.1. While this may be intentional for testnet simplicity, typically these values are differentiated to provide users with transaction priority options.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@rollups/insightly-1/chain.json` around lines 16 - 20, The gas price fields in chain.json (fixed_min_gas_price, low_gas_price, avg_gas_price, high_gas_price) are all identical; change them to a differentiated ascending set (e.g., fixed_min_gas_price < low_gas_price < avg_gas_price < high_gas_price) so users can choose priority levels—update the values for fixed_min_gas_price, low_gas_price, avg_gas_price and high_gas_price in the JSON to reflect increasing gas prices while keeping the same denom ("stake").rollups/insightly-1/assetlist.json (1)
6-10: Consider following the common pattern for denom_units.While the current single
denom_unitentry is technically valid according to the schema, the common pattern in Cosmos ecosystem asset lists is to define both a base (micro) denomination and a display denomination, even when they have the same name. This provides better clarity about the token's decimal handling.📋 Common pattern example
If this were following the typical pattern with micro-denominations:
"denom_units": [ { "denom": "ustake", "exponent": 0 + }, + { + "denom": "stake", + "exponent": 6 } ], - "base": "stake", + "base": "ustake", "name": "Stake", "display": "stake", "symbol": "STAKE"However, if you're intentionally using
stakeas the base unit without a micro-denomination, the current structure is acceptable.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@rollups/insightly-1/assetlist.json` around lines 6 - 10, Update the denom_units array to follow the common Cosmos pattern by adding both a base (micro) denomination and a display denomination: keep or add the base unit entry with exponent 0 (e.g., denom field like "u<token>" representing the atomic unit) and add a second entry for the human-friendly display denom (e.g., "stake") with exponent equal to the number of decimals (commonly 6); modify the denom and exponent fields in the denom_units array accordingly (refer to denom_units, denom, and exponent) — if you intentionally want "stake" as the atomic unit, leave as-is but otherwise add the micro-denom + display-denom pair.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@rollups/insightly-1/chain.json`:
- Line 12: The github_repository field in chain.json currently contains the
placeholder URL "https://github.com/YOUR_ORG/insightly-app"; update the
github_repository value to the actual repository URL (e.g.,
"https://github.com/RionAsari/Initiate") so the JSON reflects the real repo,
ensure the string remains valid JSON and commit the change; verify no other
references to YOUR_ORG or insightly-app remain in the file or related rollups.
- Around line 24-31: Replace the incorrect root property "key_images" with the
allowed property name "images" in the JSON object (the block containing
"image_sync", "chain_name": "initia", and "base_denom": "init"); update the key
exactly from "key_images" to "images" so the schema no longer rejects the
additional property.
In `@rollups/insightly-1/endpoints.json`:
- Around line 1-20: The endpoints.json currently lists local-only addresses for
the rpc, rest, and grpc entries (the "rpc", "rest", and "grpc" objects) which
are unsuitable for a testnet registry; update each address value from
"localhost" (e.g., "http://localhost:26657", "http://localhost:1317",
"localhost:9090") to your publicly reachable testnet endpoints or IPs (use the
actual deployed URLs/hosts and ports), keep the structure/provider fields
intact, and verify the updated endpoints are reachable from outside the local
machine before committing.
In `@rollups/insightly-1/README.md`:
- Around line 30-32: The README currently lists local endpoints for RPC, REST,
and gRPC; update these three entries (the lines containing "RPC:", "REST:", and
"gRPC:") to the public testnet addresses that correspond to the values you will
put in endpoints.json (replace "http://localhost:26657",
"http://localhost:1317", and "localhost:9090" with the public RPC, REST, and
gRPC URLs). Ensure the updated strings exactly match the public endpoints in
endpoints.json so docs and config remain consistent.
- Line 22: Update the placeholder GitHub URL in README.md by replacing the line
"GitHub: https://github.com/YOUR_ORG/insightly-app" with the actual repository
URL (e.g., "https://github.com/RionAsari/Initiate"); edit the README.md file to
ensure the GitHub link points to the real repo instead of YOUR_ORG.
In `@rollups/insightly-1/submission.json`:
- Line 34: The submission_date field currently reads "2026-04-15T23:00:00Z"
which is in the future; update the submission_date property in the JSON
(submission_date) to the actual submission/PR creation timestamp (e.g.,
"2026-03-27T08:54:18Z") or replace it with the current ISO 8601 UTC timestamp
when you finalize the submission, ensuring the value remains a valid
Zulu-formatted string.
- Around line 8-9: The submission.json contains placeholder values for
github_repo and demo_video_url; replace the github_repo value with the actual
repository URL (e.g., "https://github.com/RionAsari/Initiate") and upload the
demo video to YouTube, then replace demo_video_url with the real YouTube link;
ensure both keys (github_repo and demo_video_url) are updated to valid,
accessible URLs before merging.
---
Nitpick comments:
In `@rollups/insightly-1/assetlist.json`:
- Around line 6-10: Update the denom_units array to follow the common Cosmos
pattern by adding both a base (micro) denomination and a display denomination:
keep or add the base unit entry with exponent 0 (e.g., denom field like
"u<token>" representing the atomic unit) and add a second entry for the
human-friendly display denom (e.g., "stake") with exponent equal to the number
of decimals (commonly 6); modify the denom and exponent fields in the
denom_units array accordingly (refer to denom_units, denom, and exponent) — if
you intentionally want "stake" as the atomic unit, leave as-is but otherwise add
the micro-denom + display-denom pair.
In `@rollups/insightly-1/chain.json`:
- Around line 16-20: The gas price fields in chain.json (fixed_min_gas_price,
low_gas_price, avg_gas_price, high_gas_price) are all identical; change them to
a differentiated ascending set (e.g., fixed_min_gas_price < low_gas_price <
avg_gas_price < high_gas_price) so users can choose priority levels—update the
values for fixed_min_gas_price, low_gas_price, avg_gas_price and high_gas_price
in the JSON to reflect increasing gas prices while keeping the same denom
("stake").
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 786b4ce3-663a-44f0-9464-f60b0d224e0a
📒 Files selected for processing (5)
rollups/insightly-1/README.mdrollups/insightly-1/assetlist.jsonrollups/insightly-1/chain.jsonrollups/insightly-1/endpoints.jsonrollups/insightly-1/submission.json
- Replace placeholder URLs with actual repository (RionAsari/Initiate) - Fix property name from 'key_images' to 'images' in chain.json - Update endpoints to public testnet URLs (Initia Foundation RPC/REST/gRPC) - Update submission date to match PR creation date (2026-03-28) - Add demo video URL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit