Repository navigation
Conversation
Contributor
Benchmarks: Patchwork with this PR against main
every benchmark: the median of 3 runs of main and 3 runs of the PR, their range in brackets
|
Contributor
✅ Patchwork glance readyhttps://patchwork-preview-465.patchwork.inkandswitch.comA peek at |
accidental commit
chee
requested review from
paulsonnentag and
pvh
and
a balanced review from Copilot
October 27, 2026 05:49
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Fallback ranking mishandles equally close supertypes, and datatype registration can fail to mount the appropriate tool.
3 open issues
What changed in this PR
Adds datatype conformance so Patchwork documents can use tools for their parent types, including transitive relationships.
Changes:
- Introduces
conformsTometadata andgetSupertypes. - Extends tool matching and fallback selection to include supertypes.
- Updates legacy views to react to datatype registration, with integration tests and a changeset.
| File | Description |
|---|---|
core/plugins/src/tools.ts |
Adds supertype-aware tool matching and fallback ranking. |
core/plugins/src/datatypes.ts |
Defines conformance metadata and cycle-safe supertype traversal. |
core/elements/test/patchwork-view.test.ts |
Tests supertype selection and late datatype registration. |
core/elements/src/legacy-impl.ts |
Updates fallback handling for conformance and registration events. |
.changeset/datatype-conforms-to.md |
Records patch releases and describes the new behavior. |
Review effort: Balanced
| if (!type) return; | ||
| if (added.id != type && !getSupertypes(type).includes(added.id)) return; | ||
| const fallback = getFallbackTool(this.#handle.doc()); | ||
| if (!fallback || fallback.id == this.#fallbackId) return; |
Comment on lines
+434
to
+437
| this.#fallbackId = fallback.id; | ||
| if (!fallback.module) { | ||
| // The "loaded" listener mounts it once it's in. | ||
| if (isLoadablePlugin(fallback)) toolRegistry.load(fallback.id); |
Comment on lines
+71
to
+72
| const index = types.findIndex((type) => datatypes.includes(type)); | ||
| if (index >= 0) return index; |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
similar to https://developer.apple.com/documentation/uniformtypeidentifiers
we could declare, like
or