Skip to content

script fix for build #2188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shagun-singh-inkeep wants to merge 3 commits into
base: main
Choose a base branch
from
Open

script fix for build #2188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f9c522
script fix for build
shagun-singh-inkeep Feb 19, 2026
e5d8ecd
remove noisy instrumentation to fix tests
shagun-singh-inkeep Feb 19, 2026
2377717
changeset
shagun-singh-inkeep Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/lazy-ducks-switch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@inkeep/agents-manage-ui": patch
"@inkeep/agents-api": patch
---

script fix for manage ui
Copy link
Contributor

@claude claude bot Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Minor: Vague changeset message

Issue: The changeset message "script fix for manage ui" doesn't describe what was fixed or the user impact.

Why: Per AGENTS.md, changelog messages should use sentence case, start with an action verb (Fix, Add, Update, etc.), and be specific about what changed and why it matters to consumers. The current message resembles the "fix bug" anti-pattern called out in the guidelines.

Fix: (1-click apply)

Suggested change
script fix for manage ui
Fix prepublish script to handle scoped packages in standalone build output

Refs:

3 changes: 3 additions & 0 deletions agents-api/src/instrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ export const defaultInstrumentations: NonNullable<NodeSDKConfiguration['instrume
span.updateName(host ? `${method} ${host}${path}` : `${method} ${path}`);
},
},
'@opentelemetry/instrumentation-fs': { enabled: false },
'@opentelemetry/instrumentation-dns': { enabled: false },
'@opentelemetry/instrumentation-net': { enabled: false },
}),
];

Expand Down
31 changes: 27 additions & 4 deletions agents-manage-ui/scripts/append-hash-for-server-only-packages.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,36 @@ import appPackageJson from '../package.json' with { type: 'json' };

const NODE_MODULES_PATH = '.next/node_modules';

fs.readdir(NODE_MODULES_PATH).then(async (dirs) => {
const newAppPkgJson = structuredClone(appPackageJson);
async function collectHashedPackages(): Promise<{ dir: string; pkgJsonPath: string }[]> {
const entries: { dir: string; pkgJsonPath: string }[] = [];
const dirs = await fs.readdir(NODE_MODULES_PATH);

for (const dir of dirs) {
const pkgJsonPath = path.join('..', NODE_MODULES_PATH, dir, 'package.json');
if (dir.startsWith('@')) {
const scopePath = path.join(NODE_MODULES_PATH, dir);
const scopedDirs = await fs.readdir(scopePath);
for (const scopedDir of scopedDirs) {
entries.push({
dir: `${dir}/${scopedDir}`,
pkgJsonPath: path.join('..', NODE_MODULES_PATH, dir, scopedDir, 'package.json'),
});
}
} else {
entries.push({
dir,
pkgJsonPath: path.join('..', NODE_MODULES_PATH, dir, 'package.json'),
});
}
}

return entries;
}

collectHashedPackages().then(async (entries) => {
const newAppPkgJson = structuredClone(appPackageJson);
for (const { dir, pkgJsonPath } of entries) {
// @ts-expect-error -- ignore type error
const { default: pkgJson } = await import(pkgJsonPath, { with: { type: 'json' } });
// Add dependency with hash
newAppPkgJson.dependencies[dir] = `npm:${pkgJson.name}@${pkgJson.version}`;
}
const content = JSON.stringify(newAppPkgJson, null, 2);
Expand Down
Loading