Skip to content

fix(ci): add Dependabot for docker-compose, pin Doltgres, disable OTEL in Cypress #2240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amikofalvy wants to merge 1 commit into from
Closed

fix(ci): add Dependabot for docker-compose, pin Doltgres, disable OTEL in Cypress #2240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/composite-actions/cypress-e2e/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,20 +115,22 @@ runs:

- name: Run Cypress E2E Tests
shell: bash
run: pnpm --filter @inkeep/agents-manage-ui test:e2e:ci
run: timeout 600 pnpm --filter @inkeep/agents-manage-ui test:e2e:ci
Copy link
Contributor

@claude claude bot Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Minor: Hardcoded timeout value without documentation

Issue: The timeout 600 uses a magic number (10 minutes) without inline explanation.

Why: Future maintainers may not understand why 600 was chosen or what the relationship is to the 30-minute job timeout.

Fix: Add a brief comment:

      # 10-min timeout: fail gracefully before the 30-min job timeout
      run: timeout 600 pnpm --filter @inkeep/agents-manage-ui test:e2e:ci

Refs:


- name: Upload Cypress Screenshots
if: failure()
if: always()
uses: actions/upload-artifact@v4
with:
name: cypress-screenshots
path: agents-manage-ui/cypress/screenshots
if-no-files-found: ignore
retention-days: 7

- name: Upload Cypress Videos
if: failure()
if: always()
uses: actions/upload-artifact@v4
with:
name: cypress-videos
path: agents-manage-ui/cypress/videos
if-no-files-found: ignore
retention-days: 7
11 changes: 11 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
version: 2
updates:
- package-ecosystem: 'docker-compose'
directory: '/'
schedule:
interval: 'weekly'

- package-ecosystem: 'docker-compose'
directory: '/create-agents-template'
schedule:
interval: 'weekly'
3 changes: 2 additions & 1 deletion .github/workflows/cypress.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:

services:
doltgres:
image: dolthub/doltgresql:latest
image: dolthub/doltgresql:0.54.10
env:
DOLTGRES_USER: appuser
DOLTGRES_PASSWORD: password
Expand Down Expand Up @@ -134,4 +134,5 @@ jobs:
INKEEP_AGENTS_MANAGE_UI_PASSWORD: adminADMIN!@12
BETTER_AUTH_SECRET: test-secret-key-for-ci
SPICEDB_PRESHARED_KEY: dev-secret-key
OTEL_SDK_DISABLED: true
CYPRESS_NO_COMMAND_LOG: 1
2 changes: 1 addition & 1 deletion agents-manage-ui/src/instrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type * as SentryNs from '@sentry/nextjs';
export let onRequestError: typeof SentryNs.captureRequestError;

export async function register() {
if (process.env.NEXT_RUNTIME === 'nodejs') {
if (process.env.NEXT_RUNTIME === 'nodejs' && process.env.ENVIRONMENT !== 'test') {
await import('./otel');
}

Expand Down
Loading