[pull] main from firecrawl:main - #74
Merged
Merged
Conversation
Every request this server made to the Firecrawl API carried the constant origin `mcp-fastmcp`. It now carries `mcp-<client>@<server version>`, from the `clientInfo` the MCP client sends at initialize, which fastmcp hands to each tool call as `context.client.version`. A stateless HTTP call never sees the client's initialize, so it falls back to the User-Agent product token as `mcp-ua-<product>@<version>`, captured at authentication, and to `mcp-fastmcp@<version>` without one. The `mcp` token stays in every form, so nothing that classifies MCP traffic by it changes. - src/origin.ts owns the shape (slug rules, bounds, fallbacks) with unit tests - the developer, research and monitor tools stamp the same origin instead of their own constants - the smoke tests pin a User-Agent and read the version from package.json Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The upload-url phase of a hosted firecrawl_parse call with filePath went out without an origin, so that request could not be attributed to the client. The hosted POST helper now takes the origin and sends it as the X-Origin header on both the credentialed and the keyless path, and the smoke test asserts it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The developer, research and monitor modules declare their own SessionData, so the origin reader's optional clientUserAgent had no property in common with them and tsc refused the call. Each now names the field. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Stamp the MCP client in the request origin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 馃挅 Please sponsor : )