Skip to content

Add boot_disk_kms_key attribute for gke node pool #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thekogo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add boot_disk_kms_key attribute for gke node pool #660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/resources/google_container_node_pool.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,12 @@ end
its('initial_node_count'){should eq 3}
end

### Test GCP container node pool boot disk kms key is as expected

describe google_container_node_pool(project: 'chef-inspec-gcp', locations: 'europe-west2-a', cluster_name: 'inspec-gcp-kube-cluster', nodepool_name: 'inspec-gcp-kube-node-pool') do
its('config.boot_disk_kms_key'){should eq "projects/1234567890/locations/europe-west2-a/keyRings/inspec-gcp-kube-cluster-keyring/cryptoKeys/inspec-gcp-kube-cluster-key"}
end

## Properties
Properties that can be accessed from the `google_container_node_pool` resource:

Expand Down Expand Up @@ -111,6 +117,8 @@ Properties that can be accessed from the `google_container_node_pool` resource:
* GCE_METADATA
* GKE_METADATA

* `boot_disk_kms_key`: The Cloud KMS key to use for the boot disk attached to each node in the node pool.

* `initial_node_count`: The initial node count for the pool. You must ensure that your Compute Engine resource quota is sufficient for this number of instances. You must also have available firewall and routes quota.

* `status`: Status of nodes in this pool instance
Expand Down
3 changes: 3 additions & 0 deletions libraries/google/container/property/nodepool_config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ class NodePoolConfig

attr_reader :workload_meta_config

attr_reader :boot_disk_kms_key

def initialize(args = nil, parent_identifier = nil)
return if args.nil?
@parent_identifier = parent_identifier
Expand All @@ -72,6 +74,7 @@ def initialize(args = nil, parent_identifier = nil)
@taints = GoogleInSpec::Container::Property::NodePoolConfigTaintsArray.parse(args['taints'], to_s)
@shielded_instance_config = GoogleInSpec::Container::Property::NodePoolConfigShieldedInstanceConfig.new(args['shieldedInstanceConfig'], to_s)
@workload_meta_config = GoogleInSpec::Container::Property::NodePoolConfigWorkloadMetaConfig.new(args['workloadMetadataConfig'], to_s)
@boot_disk_kms_key = args['bootDiskKmsKey']
end

def to_s
Expand Down