Skip to content

add gulp workflow #147#148

Open
zellwk wants to merge 1 commit into
inspire-js:gh-pagesfrom
zellwk:gh-pages
Open

add gulp workflow #147#148
zellwk wants to merge 1 commit into
inspire-js:gh-pagesfrom
zellwk:gh-pages

Conversation

@zellwk

@zellwk zellwk commented Sep 23, 2016

Copy link
Copy Markdown

Signed-off-by: Zell Liew zellwk@gmail.com

Signed-off-by: Zell Liew <zellwk@gmail.com>
@LeaVerou

Copy link
Copy Markdown
Collaborator

Thanks for working on this! However, I see several issues that prevent me from merging this for now:

  • Obsolete prefixed properties and functions have been added, such as -webkit-transform or -webkit-linear-gradient(). The target browser support for this project is recent versions of evergreen browsers, since slides are a controlled environment.
  • Inline source maps add weight
  • I personally find mandatory auto-browser reload quite annoying and wouldn't want to impose it on people.
  • You didn't use git add . --all, so moved files are presented as new files, making it impossible to review their diff.

@zellwk

zellwk commented Oct 17, 2016

Copy link
Copy Markdown
Author

To be honest, I'm not sure if adding a gulp workflow would help if you don't want to:

  1. Reload the browser
  2. Preprocess / postprocess CSS
  3. Add vendor prefixes

imo, it doesn't add much value to just add cssnext, because it doesn't help much too. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants