fix: added safety promise checks in redis, mongodb#2363
Open
abhilash-sivan wants to merge 3 commits intomainfrom
Open
fix: added safety promise checks in redis, mongodb#2363abhilash-sivan wants to merge 3 commits intomainfrom
abhilash-sivan wants to merge 3 commits intomainfrom
Conversation
abhilash-sivan
force-pushed
the
fix-safety-on-promise
branch
from
03ad758 to
738b01c
Compare
kirrg001
reviewed
Feb 24, 2026
| ); | ||
| } else { | ||
| tracingUtil.handleUnexpectedReturnValue(command.promise, exports.spanName, `command "${command.name}"`); | ||
| callback(null); |
Contributor
There was a problem hiding this comment.
🤔
Do we have to do
callback = cls.ns.bind(onResult);
if
if (typeof command.promise?.then === 'function') {
is false?
Contributor
Author
There was a problem hiding this comment.
I added callback(null) for finishing the span.
The callback is bound with onResult function which finishes and transmits the span.
I agree; simply calling onResult() is much better
kirrg001
reviewed
Feb 24, 2026
| tracingUtil.handleUnexpectedReturnValue(resultPromise, exports.spanName, 'command'); | ||
|
|
||
| span.d = Date.now() - span.ts; | ||
| span.transmit(); |
Contributor
There was a problem hiding this comment.
How about we follow the finishSpan pattern?
Contributor
Author
There was a problem hiding this comment.
Yeah we can adapt that and use:
function finishSpan () {
span.d = Date.now() - span.ts;
span.transmit();
}
abhilash-sivan
commented
Feb 24, 2026
abhilash-sivan
force-pushed
the
fix-safety-on-promise
branch
from
5c9811f to
6c253b9
Compare
abhilash-sivan
force-pushed
the
fix-safety-on-promise
branch
from
6c253b9 to
d1beec0
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs https://jsw.ibm.com/browse/INSTA-70534