[NVPTX] fix ptr handling and 'byval' arg replacement in NVPTXLowerArgs #20924
+31
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
bratpiorka
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bratpiorka
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bratpiorka
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bratpiorka
force-pushed
the
rrudnick_fix_nvptx_lower
branch
from
48d958c to
f1c3201
Compare
bratpiorka
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
bratpiorka
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bratpiorka
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bratpiorka
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
bratpiorka
force-pushed
the
rrudnick_fix_nvptx_lower
branch
from
f1c3201 to
a5ab106
Compare
bratpiorka
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bratpiorka
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bratpiorka
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bratpiorka
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bratpiorka
force-pushed
the
rrudnick_fix_nvptx_lower
branch
from
a5ab106 to
f8011dc
Compare
bratpiorka
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bratpiorka
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bratpiorka
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bratpiorka
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bratpiorka
force-pushed
the
rrudnick_fix_nvptx_lower
branch
from
f8011dc to
4c2bb11
Compare
bratpiorka
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bratpiorka
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
bratpiorka
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bratpiorka
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bratpiorka
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bratpiorka
changed the title
uditagarwal97
approved these changes
Dec 22, 2025
Contributor
uditagarwal97
left a comment
uditagarwal97
left a comment
There was a problem hiding this comment.
Changes in sycl/test-e2e/FreeFunctionKernels/structs_with_special_types_as_kernel_paramters.cpp LGTM
Contributor
Author
|
@dpcpp-tools-reviewers please review |
Contributor
YuriPlyakhin
left a comment
YuriPlyakhin
left a comment
There was a problem hiding this comment.
Can it be merged to https://github.com/llvm/llvm-project ?
Contributor
Author
@YuriPlyakhin yes this is the plan - current PR is a fix for #20824 which is not merged to upstream yet (see llvm/llvm-project#170679). After the merge, I will update the upstream patch. |
YuriPlyakhin
approved these changes
Jan 2, 2026
Contributor
|
@intel/llvm-gatekeepers please consider merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in PR distinguishes between storing the pointer itself and storing through the pointer in visitStoreInst(). Additionally, it fixes a circular dependency in byval parameter handling in NVPTXLowerArgs by replacing only those uses that are not part of ArgInParam.
fixes: #20908