Skip to content

fix(bug): 🐛 #783, og:image now have a valid base64 and twitter:image property now have absolute path #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antoniotrkdz wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(bug): 🐛 #783, og:image now have a valid base64 and twitter:image property now have absolute path #850

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a64e3ce
fix(bug): 🐛 #783, og:image now have a valid base64 and twitter:image …
antoniotrkdz May 6, 2026
fbc2dcc
Merge branch 'main' into seo_image_fix
phoebus-84 May 6, 2026
eaf5021
fix(bug): 🐛 #783, og:image now have a valid base64 or an absolute pat…
antoniotrkdz May 7, 2026
6cc1c08
Merge branch 'seo_image_fix' of https://github.com/interfacerproject/…
antoniotrkdz May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions pages/project/[id]/index.tsx
View file
Open in desktop

@phoebus-84 phoebus-84 May 6, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I cant see neither og:image nor twitter:image. look in the head of the rendered html page or use online tools like https://socialsharepreview.com/ to verify what you are doing. It's a bit tricky this task and but it could help you to understand how images are handled in interfacer projects.

@antoniotrkdz antoniotrkdz May 7, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I noticed that no data was present in the head, and that was also true before the changes. I will check.

Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,18 @@ const Project: NextPageWithLayout = () => {
const { project } = useProject();
const images = useMemo(() => findProjectImages(project), [project]);

// OG/Twitter crawlers require absolute HTTP URLs — base64 data URIs don't work,
// and the /api/image proxy path needs an origin prefix.
const ogImages = useMemo(() => {
const origin = typeof window !== "undefined" ? window.location.origin : "";
return images.map((url, i) => ({
url: url.startsWith("/") ? `${origin}${url}` : url,
width: 800,
height: 600,
alt: `${project?.name}${i > 0 ? " " + i : ""}`,
}));
}, [images]);

// (Temp) Redirect if project is LOSH owned
if (process.env.NEXT_PUBLIC_LOSH_ID == project?.primaryAccountable?.id) {
router.push(`/resource/${id}`);
Expand All @@ -64,13 +76,7 @@ const Project: NextPageWithLayout = () => {
url: window.location.origin + router.asPath,
title: project?.name,
description: project?.note || undefined,
images: images?.map((image, i) => ({
url: image,
width: 800,
height: 600,
alt: `${project?.name}${i > 0 ? " " + i : ""}`,
type: project?.images?.[i]?.mimeType || "image/jpeg",
})),
images: ogImages,
siteName: "Interfacer-gui",
}}
twitter={{
Expand Down
Loading