This repository was archived by the owner on Mar 24, 2026. It is now read-only.
feat: enable shorthand vX tags inherited from latest version - #6
Open
HassanBahati wants to merge 2 commits into
Open
feat: enable shorthand vX tags inherited from latest version#6HassanBahati wants to merge 2 commits into
HassanBahati wants to merge 2 commits into
Conversation
mikehardy
approved these changes
Nov 17, 2024
| run: | | ||
| git config user.name "github-actions[bot]" | ||
| git config user.email "41898282+github-actions[bot]@users.noreply.github.com" | ||
| git tag -fa ${{ steps.get_version.outputs.major_version }} -m "Update major version tag to ${{ steps.get_version.outputs.full_version }}" |
There was a problem hiding this comment.
I've never made an annotated tag (-a) but -f looks like the way to push that semver major tag up along the releases to the current code, so +1
-a, --annotate
Make an unsigned, annotated tag object
-s, --sign
Make a GPG-signed tag, using the default e-mail address’s key. The
default behavior of tag GPG-signing is controlled by tag.gpgSign
configuration variable if it exists, or disabled otherwise. See
git-config(1).
--no-sign
Override tag.gpgSign configuration variable that is set to force
each and every tag to be signed.
-u <key-id>, --local-user=<key-id>
Make a GPG-signed tag, using the given key.
-f, --force
Replace an existing tag with the given name (instead of failing)
Contributor
Author
There was a problem hiding this comment.
basically I used the -a flag to be able to add an annotated tag object to hold metadata, for this case the message. But doesn't really add more value beyond that.
@mikehardy would recommend getting rid of the annotation and have it as simple as;
git tag -f ${{ steps.get_version.outputs.major_version }}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently to use the action you need to define the full version version eg
v1.0.0resulting intoinvertase/firebase-emulator-action@v1.0.0.This PR enables usage of
vXwhere X is any major release tag. Resulting into, for example;invertase/firebase-emulator-action@v1I have tested out this approach via custom-short-hand-tag.yaml for HassanBahati/demo-script-action@v1
