This repository was archived by the owner on Oct 4, 2026. It is now read-only.
Repository navigation
test(webv2): focus the Linear form field directly in the caret test - #368
Merged
Merged
Conversation
The caret test clicked each input only to focus it; on the CI runner a field tooltip opened over the Prompt input and intercepted the click until the test timed out. Focusing directly removes the hit-test the test never meant to exercise.
lstein
requested review from
JPPhoto,
Pfannkuchensack and
blessedcoolant
as code owners
September 29, 2026 02:20
lstein
enabled auto-merge
September 29, 2026 02:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
frontend-webv2-testsfails onmainsince501071e(#366), and on every PR that has mergedmainsince (#367, twice), on one browser test:WorkflowLinearPanel.browser.test.tsx› Linear form field entry › keeps the caret while editing an exposed text field through the project graphThe CI log shows the Prompt input was ready ("element is visible, enabled and stable"). But a
chakra-tooltip__positionerfrom the form itself "intercepts pointer events" on every retry oflocator.click, until the 15 s timeout. Each exposed field's label and reset button carries a tooltip, and on the runner one opened over the input.The test is about the caret surviving an edit's round trip through the project graph. It clicked each input only to focus it. Its
focusAtEndhelper now focuses the input directly and presses End, so there is no hit-test for a tooltip to intercept. The three tests using the helper still type, move the caret and assert selection exactly as before.Related Issues / Discussions
Unblocks #367, and any PR that merges
main.QA Instructions
pnpm -C invokeai/frontend/webv2 test:browser src/features/workflow/ui/linear/WorkflowLinearPanel.browser.test.tsx: 9 passed, 3 of 3 runs.lint:oxcandlint:tsc: clean.The failure does not reproduce locally. Before the change the test passed in every setup tried:
CallSavedWorkflowSyncRuntimetest;The evidence for the cause is the CI call log. This PR's own CI run is the confirmation.
Review
Considered and rejected: a global
beforeEachthat parks the pointer in a corner before every browser test. It would add a hover to ~1800 tests, and could not be shown to fix this case. The change here stays in the one test helper whose click was incidental.Checklist
What's Newcopy (if doing a release after this PR)