Skip to content
This repository was archived by the owner on Oct 4, 2026. It is now read-only.

test(webv2): focus the Linear form field directly in the caret test - #368

Merged
lstein merged 1 commit into
mainfrom
fix/linear-caret-test-focus
Sep 29, 2026
Merged

lstein merged 1 commit into
mainfrom
fix/linear-caret-test-focus

Conversation

@lstein

@lstein lstein commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

frontend-webv2-tests fails on main since 501071e (#366), and on every PR that has merged main since (#367, twice), on one browser test:

WorkflowLinearPanel.browser.test.tsx › Linear form field entry › keeps the caret while editing an exposed text field through the project graph

The CI log shows the Prompt input was ready ("element is visible, enabled and stable"). But a chakra-tooltip__positioner from the form itself "intercepts pointer events" on every retry of locator.click, until the 15 s timeout. Each exposed field's label and reset button carries a tooltip, and on the runner one opened over the input.

The test is about the caret surviving an edit's round trip through the project graph. It clicked each input only to focus it. Its focusAtEnd helper now focuses the input directly and presses End, so there is no hit-test for a tooltip to intercept. The three tests using the helper still type, move the caret and assert selection exactly as before.

Related Issues / Discussions

Unblocks #367, and any PR that merges main.

QA Instructions

  • pnpm -C invokeai/frontend/webv2 test:browser src/features/workflow/ui/linear/WorkflowLinearPanel.browser.test.tsx: 9 passed, 3 of 3 runs.

  • lint:oxc and lint:tsc: clean.

  • The failure does not reproduce locally. Before the change the test passed in every setup tried:

    The evidence for the cause is the CI call log. This PR's own CI run is the confirmation.

Review

Considered and rejected: a global beforeEach that parks the pointer in a corner before every browser test. It would add a hover to ~1800 tests, and could not be shown to fix this case. The change here stays in the one test helper whose click was incidental.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Meaningful regression coverage added / updated where needed; obsolete tests/code removed
  • Persisted-state and API changes include required migrations / compatibility validation
  • Relevant performance/efficiency opportunities considered; material claims have evidence
  • Material review findings resolved and relevant checks rerun
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

The caret test clicked each input only to focus it; on the CI runner a field tooltip opened over
the Prompt input and intercepted the click until the test timed out. Focusing directly removes the
hit-test the test never meant to exercise.
@lstein
lstein enabled auto-merge September 29, 2026 02:21
@lstein
lstein merged commit 5ff644c into main Sep 29, 2026
16 checks passed
@lstein
lstein deleted the fix/linear-caret-test-focus branch September 29, 2026 02:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant