This repository was archived by the owner on Oct 4, 2026. It is now read-only.
Repository navigation
feat(ui): image map current-image marker, focal-point zoom, auto-recenter - #40
Merged
Merged
Conversation
lstein
marked this pull request as draft
August 2, 2026 22:23
lstein
force-pushed
the
feat/image-map-07-marker-zoom
branch
from
August 2, 2026 22:38
e01c3ee to
3a5662d
Compare
lstein
force-pushed
the
feat/image-map-06-floating
branch
from
August 3, 2026 01:38
035de15 to
d36b46d
Compare
lstein
force-pushed
the
feat/image-map-07-marker-zoom
branch
from
August 3, 2026 01:38
3a5662d to
84be196
Compare
lstein
force-pushed
the
feat/image-map-06-floating
branch
from
August 3, 2026 02:26
d36b46d to
0a64ade
Compare
lstein
force-pushed
the
feat/image-map-07-marker-zoom
branch
2 times, most recently
from
August 3, 2026 18:19
7960b81 to
f15c9c5
Compare
lstein
marked this pull request as ready for review
August 3, 2026 18:28
lstein
force-pushed
the
feat/image-map-07-marker-zoom
branch
from
August 4, 2026 01:43
f15c9c5 to
e55f4db
Compare
lstein
force-pushed
the
feat/image-map-06-floating
branch
2 times, most recently
from
August 4, 2026 05:37
a58e9c7 to
d7e56a7
Compare
lstein
force-pushed
the
feat/image-map-07-marker-zoom
branch
from
August 4, 2026 05:37
e55f4db to
3545b1f
Compare
lstein
force-pushed
the
feat/image-map-06-floating
branch
from
August 4, 2026 14:58
d7e56a7 to
925649a
Compare
lstein
force-pushed
the
feat/image-map-07-marker-zoom
branch
2 times, most recently
from
August 4, 2026 22:32
343998e to
cc30d46
Compare
lstein
force-pushed
the
feat/image-map-06-floating
branch
2 times, most recently
from
August 5, 2026 00:31
08aa934 to
ef19bf0
Compare
lstein
force-pushed
the
feat/image-map-07-marker-zoom
branch
from
August 5, 2026 00:31
cc30d46 to
16273bb
Compare
lstein
force-pushed
the
feat/image-map-06-floating
branch
from
August 5, 2026 00:38
ef19bf0 to
8666f99
Compare
lstein
force-pushed
the
feat/image-map-07-marker-zoom
branch
from
August 5, 2026 00:38
16273bb to
aae9670
Compare
lstein
force-pushed
the
feat/image-map-06-floating
branch
from
August 5, 2026 01:18
8666f99 to
dc89f69
Compare
lstein
force-pushed
the
feat/image-map-07-marker-zoom
branch
from
August 5, 2026 01:18
aae9670 to
640ce5a
Compare
lstein
force-pushed
the
feat/image-map-06-floating
branch
from
August 5, 2026 01:21
dc89f69 to
b3136de
Compare
lstein
force-pushed
the
feat/image-map-07-marker-zoom
branch
from
August 5, 2026 01:21
640ce5a to
d36dbbb
Compare
lstein
force-pushed
the
feat/image-map-06-floating
branch
from
August 7, 2026 20:41
b3136de to
5a1e4a4
Compare
lstein
force-pushed
the
feat/image-map-07-marker-zoom
branch
from
August 7, 2026 20:41
d36dbbb to
a400674
Compare
lstein
force-pushed
the
feat/image-map-06-floating
branch
from
August 9, 2026 18:27
5a1e4a4 to
cb0be51
Compare
lstein
force-pushed
the
feat/image-map-07-marker-zoom
branch
from
August 9, 2026 18:27
a400674 to
229ff97
Compare
lstein
force-pushed
the
feat/image-map-06-floating
branch
from
August 13, 2026 03:21
cb0be51 to
78a6155
Compare
lstein
force-pushed
the
feat/image-map-07-marker-zoom
branch
from
August 13, 2026 03:21
229ff97 to
df50a10
Compare
lstein
force-pushed
the
feat/image-map-06-floating
branch
from
August 13, 2026 03:26
78a6155 to
17df57d
Compare
lstein
force-pushed
the
feat/image-map-07-marker-zoom
branch
from
August 13, 2026 03:26
df50a10 to
7ff185d
Compare
lstein
force-pushed
the
feat/image-map-06-floating
branch
from
August 13, 2026 04:36
17df57d to
73f1fd4
Compare
lstein
force-pushed
the
feat/image-map-07-marker-zoom
branch
from
August 13, 2026 04:37
7ff185d to
7115d12
Compare
lstein
force-pushed
the
feat/image-map-06-floating
branch
from
August 13, 2026 23:17
73f1fd4 to
0dc1f2d
Compare
lstein
force-pushed
the
feat/image-map-07-marker-zoom
branch
from
August 13, 2026 23:17
7115d12 to
d857e04
Compare
…nter
Ports PhotoMapAI's interaction core to the Image Map widget:
- The gold "Current Image" target now tracks the gallery selection live:
selecting anywhere (gallery grid, arrows, the map itself) restyles just
the single-point marker trace, and when the marker drifts within 10% of
a viewport edge the view recenters on it, preserving the zoom width.
Selections that originate from a map click never recenter the map under
the user's cursor.
- Custom focal-point wheel zoom and two-finger pinch (exp gain, ctrl+wheel
treated as trackpad pinch), replacing plotly's scrollZoom for its
long-standing Safari issues. Pinch-end synthetic clicks are suppressed.
- Initial view fits the 1st-99th percentile of coordinates so a few
outliers cannot dwarf the map; `uirevision` preserves the user's pan and
zoom across data refreshes.
All viewport math (percentile ranges, focal-invariant zoom, width-
preserving recenter) lives in a pure module with unit tests; the plotly
host only glues events to it.
Amended during the rebase onto the re-architected webv2:
- The current-selection accessor now comes from the gallery feature's
public interface: `getSelectedGalleryImageFromValues` is imported from
`@features/gallery/contracts` (the same helper PreviewWidgetView uses)
instead of the old `@workbench/image-actions/selectedImage`. It resolves
main's mixed image/video `GalleryItem` selection and already returns
images only, so a video selection simply clears the gold marker.
- `useWidgetValuesSelector('gallery', ...)` from @workbench/
WorkbenchContext is unchanged and keeps feeding the selector; the
map-click suppression handshake with useSelectMapImage still matches by
image name, which survives the GalleryItem round-trip.
- performance/architecture-baseline.json reformatted (one array collapsed
to a single line) to satisfy oxfmt; the drift came in with the earlier
ported baselines. No baseline values changed and the build-time
performance check passes without a recapture — all new code lands in
the lazy plotly widget chunk.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…rectness Six findings from an adversarial review of the marker/zoom/recenter work: - Wheel deltas are normalized by `deltaMode` before the exp() gain. Firefox reports a classic mouse wheel in LINES (deltaY +/-3), so read as pixels one notch zoomed 0.3% — ~230 notches to double the view — and because the handler preventDefaults, the user got neither zoom nor scroll. - The trackpad-pinch gain now applies only to trackpad-sized deltas. Browsers report a pinch as ctrl+wheel, but so is ctrl held over a real mouse, where the 10x gain on a 100px delta zoomed 2.7x in a single notch. A per-event clamp backstops every device. - The initial whole-map fit is chained off `Plotly.Plots.resize` rather than fired alongside it. The resize defers its own autosize relayout, so the fit was solved against the plot's previous dimensions — and with the axes scale-anchored, that re-solve crops one of them. The case that bites is a map mounted in a collapsed panel that is then opened. - `initialFitDoneRef` resets when the plot is purged. It stood for a layout that purging destroys, so any remount of the same component instance — StrictMode's double-mount in development — permanently lost the fit and rendered the cropped sliver the fit exists to prevent. - A third finger landing mid-pinch no longer strands the baseline. Going 2 -> 3 -> 2 fingers left the original distance in place while the fingers moved, so the next touchmove applied an arbitrary factor in one frame. - Map-click suppression is consumed before the no-marker return, and expired stamps are dropped unconditionally. A click whose selection never arrived (image deleted, or resolved to a non-image) left a stamp that swallowed the recenter for a later, unrelated gallery pick of the same name.
…at/image-map-06-floating The stale regeneration commit from the previous catch-up merge was dropped in the rebase; these numbers come from a fresh build of the rebased tree. Only the compressed sizes moved — the owned-byte and request counts were already correct on the base, which carries the image map's own sources.
lstein
force-pushed
the
feat/image-map-07-marker-zoom
branch
from
August 15, 2026 19:37
57c86da to
328d8db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 7 of the Image Map stack — PhotoMapAI's interaction core:
hoverinfo: 'skip'so it never shadows the point beneath it for clicks/hovers.scrollZoom(Safari issues). Coincident-touch pinch starts and zero/negative zoom factors are guarded; pinch-end synthetic clicks are suppressed including held-still pinches.Plotly.react— verified against the bundled plotly source thatuirevisionalone does not preserve ranges set via the publicrelayoutAPI. Percentile ranges (1st–99th) seed only the very first render.An adversarial review of this diff was run (it verified plotly semantics against the bundled source); all five findings — the false uirevision contract, the suppression-ref protocol breaks, pinch collapse, held-pinch click leak, and unhandled rejections — are fixed above, with tightened exact-value tests for the zoom math.
Testing
Pure viewport math fully unit-tested (percentiles incl. outliers/degenerate inputs, focal-invariant zoom + inverse property, exact wheel gains, non-positive factor clamp, width-preserving recenter, pad band). 907-test suite + lint + build pass at the stack top.
🤖 Generated with Claude Code