Repository navigation
fix(model-manager): stop filing VAEs without a decoder.conv_in weight as SD1 - #10029
Merged
joshistoast merged 5 commits intoNov 5, 2026
Conversation
… as SD1 The checkpoint VAE probe now refuses files whose latent width cannot be read (LTX-2.5 video/audio VAEs), instead of guessing SD1 from a "vae" file name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
joshistoast
self-requested a review
November 3, 2026 04:29
joshistoast
enabled auto-merge (squash)
November 3, 2026 04:32
Pfannkuchensack
self-requested a review
November 3, 2026 14:03
joshistoast
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A standalone LTX-2.5 video or audio VAE file (for example
ltx-2.5-22b_video_vae_bf16.safetensors) got imported as an SD1.x VAE. Its causal convs store weights asdecoder.conv_in.conv.weight, so the probe couldn't read a latent width and fell back to the filename.vaemaps to SD1 there.The checkpoint VAE probe now rejects state dicts without a 2-D
decoder.conv_in.weight, so those files stay Unknown. I also removed the name-only fallback in_get_base_or_raisesince nothing can reach it anymore.Related Issues / Discussions
Related to #9777
Related to #9780
QA Instructions
uv run --no-sync pytest tests/backend/model_manager/configs -n 4 --ignore tests/backend/model_manager/configs/test_ministral3_encoder_config.py: 894 passed, 1 skipped.uv run --no-sync pytest tests/backend/model_manager/configs/test_ministral3_encoder_config.py: 11 passed. I ran it on its own because its big temp safetensors files filled my nearly full disk under-n 4(ENOSPC).uv run --no-sync pytest tests/backend/model_manager/configs/test_vae_base_identification.py -k decoder_conv_inwithvae.pyfrom main: 2 failed (both cases resolve to SD1). They pass with the fix.ruff checkandruff format --checkare clean onvae.pyandtest_vae_base_identification.py.tests/model_identification(no LFS fixtures here).Review
No material findings.
Compatibility / Rollout
No migration. Models already registered as SD1 VAEs from earlier imports keep their entry until removed and re-scanned. No API or persisted-schema changes.
Checklist
AI use
I drafted this with an AI coding assistant and checked it by running the tests listed above.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.