Repository navigation
Conversation
joshistoast
left a comment
There was a problem hiding this comment.
I'd also like to see the design more closely mirror the generate widget.
| ) : null} | ||
| </Collapsible.Trigger> | ||
| <Collapsible.Content> | ||
| <Stack borderTopColor="border.subtle" borderTopWidth="1px" gap="3" p="2"> |
There was a problem hiding this comment.
[P2] Preserve row layout inside grouped sections.
Heading grouping applies inside row containers, but section bodies always use a vertical Stack. A row containing a heading and two fields therefore displays vertically in View while remaining horizontal in Edit. Preserve the parent layout and add coverage for a headed row.
There was a problem hiding this comment.
Thanks for catching this! Fixed in 803f1aa.
Section bodies now preserve their containing group's row/column layout, including nested containers and root rows. I added browser regression tests using real numeric fields that reproduced the issue before the fix and now verify side-by-side placement and retained values after collapsing and reopening.
The headed-row case was also checked manually in the matching alpha.3 build.
I also added the thin separator between adjacent collapsed sections, matching the Generate widget for a more consistent appearance.
Preserve root and nested row/column layouts when grouping headed form sections. Match Generate headers and keep a single closed-section boundary across layout containers. Default section spacing to 8 px while preserving valid saved preferences. Add browser coverage for layouts, nested boundaries, section state and the spacing setting.
|
Thanks for the design feedback. In 803f1aa, I've aligned the accordion headers with the native Generate styling and removed the extra outer card border. The thin separator now works between adjacent closed sections across layout containers too, and disappears when either neighbor opens. I've also reduced the default section spacing to 8 px for a more compact initial presentation. The adjustable 4–36 px range remains available, and existing saved spacing preferences are preserved. Local validation passed: 145 targeted unit/architecture tests, 43 Chromium browser tests, TypeScript, formatting/lint and the production build. Would this address your design concern? (As a related observation, I find the spacing between accordion sections on the Generate page a little too tight. With so many parameters, the sections can start to blend together visually. A few extra pixels of spacing would make them easier to distinguish and scan—a view shared by several colleagues who have looked at the interface.) |
Merge origin/main at 35d08c8 without rewriting the published feature commits. Record build and browser measurements and document the unchanged alpha.4 control comparison. Performance gate rules remain unchanged.
|
I've pushed 83b67b690e, merging current main and refreshing the performance baselines after reproducing the original CI failure. Compared with an unchanged alpha.4 control, the activated Workflow payload adds 5,714 raw bytes with no extra requests. The documented baseline procedure also records other routes and Windows-specific timings; general budget rules are unchanged. The measurements and two additional Workflow source owners are explained in Local verification passed 146 targeted unit/architecture tests, 44 browser tests, both performance gates with the unchanged control reference, the project-file journey and 21 accessibility journeys. The full Windows unit suite still has five AltGr/number-formatting failures, all reproduced in the unchanged control. A matching alpha.4 build was also installed, hash-verified and visually smoke-tested. The new frontend test workflow is awaiting maintainer approval. Could a maintainer approve the new runs when convenient? Thank you. |
joshistoast
left a comment
There was a problem hiding this comment.
Another note or so on implementation:
- It looks like this is changing the behavior of headings, I'd much rather this be a new form type or offer an option to headings to be a collapsible section.
- Remove the gap preference, it should be the same as the generate and video widgets.
…on gap Add a Collapsible section checkbox to Heading cards in the form builder so existing headings remain static unless enabled. Remove the workflowFormSectionGapPx preference and use the 4 px (gap=1) spacing from the Generate and Video widgets.
|
Thanks for the follow-up feedback — I've updated the PR in 4850b3dd03 with both changes:
Why I originally added the spacing option (UX feedback on
|

Summary
Long workflow forms make it difficult to find the controls for a particular stage. This change turns existing form headings into native, independently collapsible sections. Workflow authors can use their existing Heading and Divider elements without changing the workflow document format or execution graph.
Collapsiblesupplies the button/content association andaria-expanded. Pointer, Enter-key activation and remount restoration are covered by browser tests.Related Issues / Discussions
No linked issue.
QA Instructions
Manual reproduction
Screenshots
Expanded and collapsed sections, using the original theme colors: expanded controls stay grouped, while collapsed headers use the normal panel background. The “Needs attention” markers indicate unfilled required fields in this example.
Adjustable spacing: the Workflow widget settings expose the section gap in pixels; this example shows a 16 px setting. The revised PR default is 8 px.
Local automated checks
The results below are local verification of follow-up
83b67b690e, not a claim that the GitHub Actions checks have passed.Run from
invokeai/frontend/webv2:src/architecturetests: 146 passed, including the CI workflow structure tests with the unmodified upstream.githubfiles present.performance/accordion-resource-review.md. The full baseline refresh also records other routes and Windows-specific timings, rather than changing only the Workflow byte values. General budget rules are unchanged.A separate matching
v7.0.0-alpha.3build containing both native features was installed with an original-frontend backup, verified against its full SHA-256 manifest, and manually tested in a live browser. The original combined build's appearance, spacing slider and color functionality were confirmed. The revised preview also passed manual layout/boundary checks with the column heading outside its container, first inside it, and between two fields. Its local checks passed 52 browser tests and 98 targeted unit/architecture tests, including three local import-fixture checks. This runtime package and fixture are not included in the PR.That tested local build retains the earlier 16 px default. The source PR subsequently reduces the default to 8 px, covered by the renderer, settings-dialog and preference tests above; valid stored spacing values remain unchanged.
A new accordion-only
v7.0.0-alpha.4distribution has also been built from the exact release source, with 269 SHA-256-manifested files, matching source provenance, passing TypeScript/format/lint checks, 44 browser tests and 18 offline installer/rollback tests. The user installed it, verified the complete installed-file and original-backup manifests, and confirmed that the initial live browser appearance looks good. This is an initial visual confirmation, not a manual acceptance claim for every interaction or a live rollback test. That distribution is not included in the source PR.Review
35d08c870cdc79ffbef30b64d1eb9331d86b0858through a normal merge without rewriting the published feature commits. That upstream frontend matches the alpha.4 release. The new resource baselines and performance review note are included for maintainer review.Changed files
Paths relative to
invokeai/frontend/webv2:Compatibility / Rollout
Expansion is stored by workflow ID and stable heading element ID in the existing project widget values. Missing or malformed saved states leave sections expanded. Expansion does not modify the authored workflow JSON or execution graph.
Section spacing uses the existing account-owned preference store and defaults to 8 px when no valid value is present. Valid saved values, including an earlier 16 px preference, are retained. In default single-user mode, the server uses a shared identity; account separation requires InvokeAI authentication. No database or API migration is introduced.
This is independent of the Appearance color-adjustments PR. It contains no color controls, custom-node injection, Python backend patches, installer scripts or compiled frontend distribution.
Checklist
performance/accordion-resource-review.md; UI help and reproduction instructions are included.What's Newcopy (if doing a release after this PR) — Not applicable: this PR is not a release.