Repository navigation
fix(flux3): point the single-file starters at the renamed Comfy files - #10091
Pfannkuchensack wants to merge 3 commits into
Conversation
The Comfy repository removed the underscore-named FLUX.3 files on 2026-10-17, so both single-file starters failed with 404. They now download the hyphenated files at a pinned revision.
joshistoast
left a comment
There was a problem hiding this comment.
A nit that I think is worth addressing
| base=BaseModelType.Flux3, | ||
| source="https://huggingface.co/black-forest-labs/flux-3-image-klein-comfy/resolve/main/diffusion_models/" | ||
| "flux3_image_klein_sd_bf16.safetensors", | ||
| source="https://huggingface.co/black-forest-labs/flux-3-image-klein-comfy/resolve/feef60b0aaf63a4773ace96636ebbcf43b881312/diffusion_models/flux3-image-klein-bf16.safetensors", |
There was a problem hiding this comment.
[P3] Renamed existing installations appear uninstalled.
The URL change and line 58 breaks source matching for previously installed models. If the user also renamed the model, get_is_installed() cannot recognize it through its name fallback, offering a redundant ~11 GB download. Recognizing the previous URLs as source aliases would preserve this behavior. Default-name installations remain recognized.
Starters list previous_sources so renamed installs from an old URL are not offered again; FLUX.3 single-file starters use it.
|
Fixed in f0be6f6. Starters can now list |
Summary
Installing FLUX.3 Klein (single file) or FLUX.3 Klein Base (single file) from the starter models fails with HTTP 404. On 2026-10-17,
black-forest-labs/flux-3-image-klein-comfydeleted its underscore-named diffusion models (commit94a2e33818) after adding the same files under hyphenated names.Both starters now download
diffusion_models/flux3-image-klein-bf16.safetensorsanddiffusion_models/flux3-image-klein-base-bf16.safetensors, pinned to revisionfeef60b0aaf63a4773ace96636ebbcf43b881312, so another rename cannot break them. The files are the same LFS objects as before, and as BFL's ownmodel.safetensors(Kleinc3e9813c…, Base5c921759…), so installed models and their hashes do not change.The FLUX.3 Klein key fixture's docstring named the old file and a local path; it now names the repository paths.
Related Issues / Discussions
Follow-up to #9883.
QA Instructions
curl -Ion the oldresolve/main/...flux3_image_klein_sd_bf16.safetensorsand...flux3_image_klein_bf16.safetensorsreturns 404; both new pinned URLs return 302.pytest tests/backend/model_manager/test_starter_models.py tests/backend/model_manager/test_starter_models_package.py tests/backend/model_manager/configs/test_flux3_main_config.py: 30 passed.ruff checkandruff format --checkon the changed files: clean.c3e9813cdd049c831c836b2e9db61150e49a93fc1a4c63b256494642fee0bd7c, the LFS oid of the new file.Review
No material findings. A model installed from the old URL still shows as installed, because the installed check falls back to name, base and type when the source differs.
Checklist
What's Newcopy (if doing a release after this PR)Need help on this PR? Tag
@codesmith-botwith what you need.