Repository navigation
feat(canvas): restore eraser pressure width, layer quick switch, crop tools and middle-click open - #9808
Open
joshistoast wants to merge 2 commits into
Open
feat(canvas): restore eraser pressure width, layer quick switch, crop tools and middle-click open#9808joshistoast wants to merge 2 commits into
joshistoast wants to merge 2 commits into
Conversation
…iddle-click open Eraser honours pen pressure for width through its own Dynamics switch; Alt+[ / Alt+] cycle layers when nothing is staged and Q jumps to a bookmarked or previous layer via engine-held memory and a layer-menu bookmark. Reference crop dialog gains aspect-ratio presets, wheel zoom, Space/middle-button pan, view buttons and Save to Uploads; Gallery gets an opt-in middle-click-opens-in-new-tab setting on image and video tiles.
…rops free Reference crop: Space pans only when no button or field has focus, the aspect preset is restored only for a saved partial crop, the ratio Select carries an accessible name, Save to Uploads targets the Gallery auto-add board, and the crop geometry lives in the reference image core so the editor startup graph is unchanged. Canvas: Alt+] enters a selected group at its first leaf and Alt+[ leaves it upward.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four interaction behaviors from the legacy frontend were missing from webv2.
Related Issues / Discussions
Follows up the legacy parity audit behind #9803.
QA Instructions
From
invokeai/frontend/webv2(Node 22.14, pnpm 10.12):pnpm check:releasepasses; no baseline changes (the crop geometry lives in the already-eagercore/referenceImage.ts, so the editor's source-owner set is unchanged).Mock backend (representative profile):
Review
Material findings resolved: Space was swallowed for every button in the crop dialog (keyboard users could not activate Apply/Cancel with Space); the dialog opened ratio-locked for any image whose full frame matched a preset; the aspect-ratio combobox had no accessible name. Also applied: a selected group now cycles from its first leaf, Save to Uploads honours the auto-add board, and browser tests cover wheel zoom, pan and Space activation. Remaining limitation: "Actual size" assumes the fitted image spans the viewport width; a very tall image capped by the dialog height is slightly off (pre-existing crop-percentage behavior).
Compatibility / Rollout
The new Gallery setting is optional and off by default; bookmark and previous-selection memory are never persisted. No API changes.
Checklist
What's Newcopy (if doing a release after this PR)🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.