refactor: extract shared Luhn check digit and party tax ID helpers#773
Open
pablocaeg wants to merge 1 commit intoinvopop:mainfrom
Open
refactor: extract shared Luhn check digit and party tax ID helpers#773pablocaeg wants to merge 1 commit intoinvopop:mainfrom
pablocaeg wants to merge 1 commit intoinvopop:mainfrom
Conversation
Add luhn.CheckDigit() to pkg/luhn, replacing identical computeLuhnCheckDigit implementations in the FR and IT regimes. The existing pkg/luhn package already provided Check() for validation but lacked the complementary check digit computation. Add Party.HasTaxIDCode() method to org.Party, replacing identical hasTaxIDCode/partyHasTaxIDCode helpers duplicated across the BE, DE, DK, FR, NL regimes, the bill package, and the IT SDI addon.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #773 +/- ##
==========================================
- Coverage 93.05% 93.04% -0.02%
==========================================
Files 333 333
Lines 17796 17770 -26
==========================================
- Hits 16560 16534 -26
Misses 870 870
Partials 366 366 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed duplicate helper functions while reading through the regimes:
computeLuhnCheckDigitwas identical inregimes/frandregimes/it(both had a TODO asking for this). Addedluhn.CheckDigit()to the existingpkg/luhnpackage and replaced both.hasTaxIDCode/partyHasTaxIDCodewas duplicated acrossregimes/be,regimes/de,regimes/dk,regimes/fr,regimes/nl,bill, andaddons/it/sdi. AddedParty.HasTaxIDCode()toorg.Partyand replaced all seven.Pre-Review Checklist
go generate .to ensure that the Schemas and Regime data are up to date.