This repository was archived by the owner on May 1, 2020. It is now read-only.
feat(IonicPage): add config option for module filename#1140
Open
jakiette wants to merge 1 commit intoionic-team:masterfrom
Open
feat(IonicPage): add config option for module filename#1140jakiette wants to merge 1 commit intoionic-team:masterfrom
jakiette wants to merge 1 commit intoionic-team:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
When using IonicPage on a component, the module file name is assumed to be the page's file name with ".module.ts" appended. This conflicts with different naming conventions users might use, such as Angular's "<feature>.<type>.ts" as it will name the module "<feature>.<type>.module.ts". This leads to errors with different naming structures one might use beyond Angular's even.
Changes proposed in this pull request:
It was mentioned the suffix itself is configurable in the below linked issue, therefore the regular set suffix is used even with the different file base name option to avoid redundancy.
Fixes: #1093
Note: This needs changes to the IonicPage metadata type which needs to be modified in the ionic-angular module.