Repository navigation
Conversation
Closed
Javascript size report
❌ Size increased +5.5% — exceeds the 5% threshold. |
abkfenris
commented
Oct 14, 2026
abkfenris
left a comment
abkfenris
left a comment
Collaborator
Author
There was a problem hiding this comment.
It should be possible to generate only a subset of test configs, and interpret what arguments/constants are needed for just those configs.
Currently:
cargo run qc config sea_surface_temperature qartod_manual mean=5 std=3 sensor_min=1 sensor_max=1
5
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.08s
Running `target/debug/standard_knowledge qc config sea_surface_temperature qartod_manual mean=5 std=3 sensor_min=1 sensor_max=15`
Error generating configuration: Missing required argument: min_var_failIn theory the gross_range_test shouldn't need min_var_fail
If a --tests=gross_range_test,flat_line_test type of argument that could limit to specific tests to get it to pass, and if that's not passed, list what variables are needed for which test in the error, rather than just the first missing argument.
abkfenris
force-pushed
the
qartod-manual-suites
branch
from
October 15, 2026 16:16
cd9ac38 to
345b568
Compare
abkfenris
force-pushed
the
qartod-manual-suites
branch
from
October 15, 2026 16:19
345b568 to
c7c7105
Compare
abkfenris
force-pushed
the
qartod-manual-suites
branch
from
October 19, 2026 13:54
c7c7105 to
d5cad37
Compare
abkfenris
force-pushed
the
qartod-manual-suites
branch
from
November 10, 2026 14:00
d5cad37 to
e4163bb
Compare
abkfenris
force-pushed
the
qartod-manual-suites
branch
from
November 10, 2026 14:17
e4163bb to
f80b8f9
Compare
abkfenris
force-pushed
the
qartod-manual-suites
branch
from
November 10, 2026 14:40
f80b8f9 to
63a7438
Compare
Adds ioos_qc's attenuated_signal_test to the config schema, and a qartod_manual suite for the standards covered by the Temperature and Salinity, Water Level, Dissolved Oxygen, pH and Winds manuals. Each derives its thresholds with fx expressions from statistics of a historical record that the caller passes as arguments, following the manuals' recipes (for example N_DEV x SD over TIM_DEV for rate of change, converted to units per second). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LuWEgV29DBhxXmYcc8jnmJ
…gument `qc config --tests gross_range_test,flat_line_test` (and TestSuite.scaffold(arguments, tests=[...]) in Python) builds only those tests, and only requires the arguments and `let` constants they read. The missing-argument error now lists, for each argument, the tests that need it. Assisted-by: Claude Code:claude-opus-5-5 Assisted-by: Claude Code:claude-fable-5-2
abkfenris
force-pushed
the
qartod-manual-suites
branch
from
November 11, 2026 00:28
63a7438 to
1e4accd
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds dynamic QARTOD test suites from the manuals using the
fxparsing language in YAML.Standards:
mass_concentration_of_oxygen_in_sea_watersea_surface_height_above_geopotential_datumsea_surface_temperaturesea_water_ph_reported_on_total_scalesea_water_practical_salinitysea_water_temperaturewind_speedReplaces #321 (recreated as a same-repo stacked PR with linear history).