Repository navigation
Conversation
Fourteen tests started an e2e server and never called teardown, so the server kept its ports and DB paths for the rest of the package run. A later test that uses the default ports from initCfg then fails with "address already in use", depending on test order. Defer teardown right after newE2ETest in each of them. The contract staking tests are left as they are: checkStakingViewInit already stops their server and tears down the one it restarts.
|
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (62.84%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #5061 +/- ##
===========================================
- Coverage 74.83% 62.84% -12.00%
===========================================
Files 378 503 +125
Lines 31624 50389 +18765
===========================================
+ Hits 23666 31667 +8001
- Misses 6747 15000 +8253
- Partials 1211 3722 +2511 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourteen e2e tests start a server with
newE2ETestand never callteardown(). The server keeps listening and keeps its DB paths until the package run ends. A later test that uses the default ports frominitCfgthen fails withlisten tcp :14014: bind: address already in use, depending on test order. For example, any test run afterTestNativeStakingVoteBugthat uses the default gRPC port.This adds
defer test.teardown()right afternewE2ETestin:blobtx_test.go:TestBlobTxdynamicfee_tx_test.go:TestDynamicFeeTxerigon_test.go:TestErigonArchiveContractnative_staking_test.go:TestNativeStakingVoteBug,TestCandidateBLSPublicKey,TestCandidateBLSPoPsetcodetx_test.go:TestSetCodeTx_E2E,TestSetCodeTx_BatchTransfer,TestSetCodeTx_ERC20ApproveAndTransfer,TestSetCodeTx_GasSponsorship,TestEstimateGastrace_block_test.go:TestTraceBlockByNumber,TestTraceBlockByNumberPrestateTracer,TestTraceBlockPerTxIsolationThe contract staking tests (
TestContractStakingV1/V2/V3,TestStakingViewInit) are left unchanged.checkStakingViewInitalready stops their server and tears down the one it restarts, so a deferred teardown would stop an already stopped service (service is in wrong state).Test only, no production code.
go test ./e2etest/passes.🤖 Generated with Claude Code