Conversation
The collapsed thinking preview built `thinking: <preview>` against a fixed 60-column budget and ignored the actual terminal width. Terminals narrower than ~70 columns crashed pi-tui's render with `Rendered line N exceeds terminal width (60 > <cols>)` because the custom component emitted a line wider than the terminal. Wrap the composed line in an outer `truncateToWidth(line, max(1, width), "...", false)` so very narrow terminals (33-col user report) get a clipped one-line preview instead of an overflow throw. The inner 60-col preview budget still hugs the wide-terminal target; the outer clip is a safety net.
Contributor
Author
|
Already shipped via direct push to v0.1.3 release branch and to main. Closing without merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-closed. The narrow-terminal thinking-preview fix is already on main as efc2b9e and on the v0.1.3 release branch as 8fa265d. This PR exists only to dismiss the GitHub 'Compare & pull request' banner.