Changes for new iron version 0.7 with hyper 0.12 and removed limit_reader#82
Open
zgtm wants to merge 2 commits intoiron:masterfrom
Open
Changes for new iron version 0.7 with hyper 0.12 and removed limit_reader#82zgtm wants to merge 2 commits intoiron:masterfrom
zgtm wants to merge 2 commits intoiron:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reflects that irons request body no longer implements the
Readtrait (due to hyper using futures, now) and uses the helper functioniron::request::get_body_contents()instead.Because of that, the
LimitReadertrait is no longer of use here. Instead, one should explore the possibility to implement limited reading iniron::request::get_body_contents()instead.