Add mount! macro to simplify the construction of Mount objects#79
Open
jpmartin2 wants to merge 2 commits intoiron:masterfrom
Open
Add mount! macro to simplify the construction of Mount objects#79jpmartin2 wants to merge 2 commits intoiron:masterfrom
jpmartin2 wants to merge 2 commits intoiron:masterfrom
Conversation
|
@iron-bot any thoughts on this? |
untitaker
reviewed
Feb 19, 2017
| /// ```ignore | ||
| /// let mut mount = Mount::new(); | ||
| /// mount.mount("/", index); | ||
| /// mount.mount("/:query", queryHandler); |
Member
There was a problem hiding this comment.
Hmm, this example suggests that mount can deal with variables in paths when it only matches by prefix. Also your macro example says router!, not mount!.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been doing some work on a simple web application in rust using iron, and while creating the routes for it, I noticed that the router crate had a convenient macro to create the router handler, but mount doesn't. I wanted to be able to write
This PR adds the mount! macro so you can write that instead of