Skip to content

Allow hints to generate content errors #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sjd210 merged 2 commits into from
Aug 26, 2026
Merged

Allow hints to generate content errors #827

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82e8ca1
Allow hints to generate content errors
jacbn Aug 24, 2026
625704d
Include hint-checking logic in inline regions
jacbn Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions src/main/java/uk/ac/cam/cl/dtg/segue/etl/ContentIndexer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,9 +554,28 @@ public static Set<Content> flattenContentObjects(final Content content) {
setOfContentObjects.addAll(flattenContentObjects((Content) child));
}

if (content instanceof InlineRegion) {
for (IsaacQuestionBase child : ((InlineRegion) content).getInlineQuestions()) {
setOfContentObjects.addAll(flattenContentObjects(child));
if (content instanceof IsaacQuestionBase question) {

@sjd210 sjd210 Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hints don't just exist on a Question, they can also be part of an InlineRegion - so we ought to also add this logic to the if statement below this as well. e.g. See sjd_inline_region_no_questions

@jacbn jacbn Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot! I've also aligned the inlineQuestions loop to include a null-check, just in case.

List<ContentBase> hints = question.getHints();
if (hints != null) {
for (ContentBase hint : hints) {
setOfContentObjects.addAll(flattenContentObjects((Content) hint));
}
}
}

if (content instanceof InlineRegion region) {
List<IsaacQuestionBase> inlineQuestions = region.getInlineQuestions();
if (inlineQuestions != null) {
for (IsaacQuestionBase child : inlineQuestions) {
setOfContentObjects.addAll(flattenContentObjects(child));
}
}

List<ContentBase> hints = region.getHints();
if (hints != null) {
for (ContentBase hint : hints) {
setOfContentObjects.addAll(flattenContentObjects((Content) hint));
}
}
}
}
Expand Down