Skip to content

Use correct submission method for fasttrack inlines - #2359

Merged
barna-isaac merged 2 commits into
mainfrom
hotfix/submit-inlines-inside-fasttrack
Sep 11, 2026
Merged

Use correct submission method for fasttrack inlines#2359
barna-isaac merged 2 commits into
mainfrom
hotfix/submit-inlines-inside-fasttrack

Conversation

@jacbn

@jacbn jacbn commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Inline questions should be submitted via submitInlineRegion; FastTrack questions were using a different submit button that did not have the onClick override that used to be in place for inline regions on the main button. This PR refactors the flow a little so all question attempts pass through the same onSubmit handler, ensuring both regular and FT inline questions submit using the same logic.

@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.53%. Comparing base (db64a99) to head (5ef0de6).

Files with missing lines Patch % Lines
src/app/components/content/IsaacQuestion.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2359   +/-   ##
=======================================
  Coverage   43.53%   43.53%           
=======================================
  Files         601      601           
  Lines       25887    25887           
  Branches     8622     8600   -22     
=======================================
  Hits        11269    11269           
  Misses      14561    14561           
  Partials       57       57           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@barna-isaac barna-isaac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Also changes the focused element after submission for an inline question that's not fast-track, but I don't see that being a bad change (pressing Tab after submit previously landed on the flag, it now lands on the feedback navigation).

@barna-isaac
barna-isaac merged commit 4837eb7 into main Sep 11, 2026
10 checks passed
@barna-isaac
barna-isaac deleted the hotfix/submit-inlines-inside-fasttrack branch September 11, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants