Factorized backprojection - #346

Open

bhawkins wants to merge 253 commits into

isce-framework:developfrom

bhawkins:factorized_bp

This pull request is big! We're only showing the most recent 250 commits

Commits on May 12, 2024

add FFBP first stage algorithm
bhawkins
committed
ee7bb32
return pointer instead of vector to avoid copy in bindings
bhawkins
committed
2f36e1c
clang confused by auto
bhawkins
committed
6cdcfe2
add python bindings
bhawkins
committed
a361b92

Commits on May 13, 2024

don't collapse to avoid extra sqrt calls
bhawkins
committed
9011c04
strides are in bytes
bhawkins
committed
c46501d
add unit test
bhawkins
committed
1c32c5e

Commits on May 14, 2024

add missing include
bhawkins
committed
a892394
baseband the images
bhawkins
committed
23d8f84
wip last stage of ffbp
bhawkins
committed
af22cf9

Commits on May 17, 2024

Merge branch 'develop' into factorized_bp
bhawkins
committed
d5e0a15
initial algorithm for final stage
bhawkins
committed
bacd5e8
Python bindings for final stage
bhawkins
committed
ccb02bf
add final stage to unit test
bhawkins
committed
d78de4f

Commits on May 19, 2024

add class for 2D NFFT
bhawkins
committed
11bd6fa
add NFFT2d::sizes attribute
bhawkins
committed
3e352e7
add some methods to help debugging
bhawkins
committed
ffd9e9f
add incomplete unit test to help debug set_spectrum
bhawkins
committed
2380081
fix indexing bugs in NFFT2d::set_spectrum
bhawkins
committed
7113d6b
Use NFFT2d to interpolate sub-images
bhawkins
committed
f9c3cfc
reduce factor size in ffbp unit test
bhawkins
committed
b67a905
fix indentation and add missing openmp pragma
bhawkins
committed
3ba97aa

Commits on May 26, 2024

Merge branch 'develop' into factorized_bp
bhawkins
committed
2e0c902

Commits on May 27, 2024

add factorization option to top-level workflow
bhawkins
committed
a3c1904
Fix indexing bug
bhawkins
committed
de9dd68
Add debug layer for factors and tweak logging
bhawkins
committed
c85f379
dump progressively for the impatient
bhawkins
committed
d0f84fb

Commits on May 28, 2024

add option to disable periodic domain for NFFT
bhawkins
committed
36541cb
Don't use periodic interpolation for FBP
bhawkins
committed
ca51ab9

Commits on May 30, 2024

Merge branch 'develop' into factorized_bp
bhawkins
committed
9db6dcd

Commits on Jun 2, 2024

Always use nice FFT sizes for polar grid
bhawkins
committed
5c3fabd
Avoid integer overflow
bhawkins
committed
7886509
wip project one subimage at a time
bhawkins
committed
ff7b974
Make a separate function for indexing junk
bhawkins
committed
440bf22

Commits on Jun 3, 2024

add interface to avoid allocations
bhawkins
committed
9085e2a
make NFFTParams default constructable
bhawkins
committed
20b853d
allow empty radar grids
bhawkins
committed
0f7405f
add python bindings
bhawkins
committed
0eaee55

Commits on Jun 24, 2024

Merge branch 'develop' into factorized_bp
bhawkins
committed
4d7b98d

Commits on Jul 1, 2024

Add helper for geogrid -> XYZ conversions
bhawkins
committed
394e16b

Commits on Jul 29, 2024

Python bindings: add polar grid ctor, fix a stride bug, and enable array conversions.
bhawkins
committed
438e255

Commits on Aug 13, 2024

Commits on Aug 14, 2024

log timing of FBP steps
bhawkins
committed
2b34ecc

Commits on Aug 16, 2024

GPU interp2d
bhawkins
committed
f0a02da
GPU NFFT2d
bhawkins
committed
f8136b1
expose secret macro to cmake
bhawkins
committed
07957d4
GPU projectPolarToGeo
bhawkins
committed
c81f8ea
WIP CUDA_HOSTDEV geo2polar
bhawkins
committed
12803d8

Commits on Aug 28, 2024

Merge branch 'develop' into factorized_bp
bhawkins
committed
12d871b

Commits on Apr 11, 2025

Merge branch 'develop' into factorized_bp
bhawkins
committed
ab84e1a

Commits on Apr 14, 2025

Move polar grid setup into standalone function.
bhawkins
committed
ef03a01
add PolarGrid.shape property to Python bindings
bhawkins
committed
c24f0e3

Commits on Apr 16, 2025

Fix ob1 error and start Doppler.
bhawkins
committed
6e47958
Add repr method for PolarGrid
bhawkins
committed
98530c0
Add repr for Linspace
bhawkins
committed
dc68e88
Add polar2polar algorithm
bhawkins
committed
5dba196
kludge clang openmp bug
bhawkins
committed
a7d63b8
add mergePolarGrids function
bhawkins
committed
4e96478
Merge branch 'develop' into factorized_bp
bhawkins
committed
60464f2
document NFFT2d (one year later!)
bhawkins
committed
a4cf75b
Add helper for NFFT2d interpolation
bhawkins
committed
149a717
Allow const input data for one-shot FFTs.
bhawkins
committed
08260be
Allow const input data for one-shot FFTs.
bhawkins
committed
79336d4
Revert "Allow const input data for one-shot FFTs."
bhawkins
committed
096c1e6
Merge branch 'const_input_fft' into factorized_bp
bhawkins
committed
f980e08

Commits on Apr 17, 2025

refactor and add NFFT2d bindings
bhawkins
committed
3bd3166
avoid copy
bhawkins
committed
1e1ab6e
separate NFFT from FBP final stage
bhawkins
committed
5d8c148
refactor to use new makeImageNFFT2d code
bhawkins
committed
8019d82
add look_side to PolarGrid
bhawkins
committed
7d7f7c9
move prototype into cpp file
bhawkins
committed
77886e8
add PolarGrid.look_side to Python bindings
bhawkins
committed
46c3a3c

Commits on Apr 18, 2025

save factors to HDF5
bhawkins
committed
db0c1e9
add script for making GIF of factorization
bhawkins
committed
7b29ff0
add parsers for FBP junk
bhawkins
committed
c23116e
remove unnecessary ellipsoid parameter
bhawkins
committed
1ef6f94
add algorithm for middle stages
bhawkins
committed
d2e5b86

Commits on Apr 21, 2025

fix bug when padding input to makeImageNFFT2d
bhawkins
committed
49ec6d1
guard against excessive Doppler resolution
bhawkins
committed
113b316
first version of multi-stage fbp workflow
bhawkins
committed
55fdab7

Commits on Apr 22, 2025

eliminate redundant polar2geo calculations
bhawkins
committed
502e464
limit doppler resolution
bhawkins
committed
9925e99

Commits on Apr 23, 2025

more detailed log messages
bhawkins
committed
5d96a0b
move dq calculation to separate function
bhawkins
committed
c2ed666
Use average rather than min dq and allow user to specify scaling constant.
bhawkins
committed
83470dc

Commits on Apr 24, 2025

fix one-left-over edge case
bhawkins
committed
a013875
get cuda compiling again
bhawkins
committed
af365f2
gcc 9.4.0 openmp fixes
bhawkins
committed
3a3cfbb
fix formatting
bhawkins
committed
8028226
don't copy/paste prototypes
bhawkins
committed
e7abfe9
remove duplicate include
bhawkins
committed
a04ba16
repeat some refactoring for cuda
bhawkins
committed
818e3a4
avoid overflow
bhawkins
committed
db9de28
update cuda bindings
bhawkins
committed
28c4b71

Commits on Apr 25, 2025

refactor to delete redundant code
bhawkins
committed
d858e6e
expose more algorithm knobs in config file
bhawkins
committed
512170a

Commits on Apr 28, 2025

add python bindings to view NFFT2d spectrum
bhawkins
committed
11aa97b

Commits on Apr 29, 2025

Add Python bindings for polar2geo_bracket
bhawkins
committed
c80bab4

Commits on Apr 30, 2025

Implement bistatic corrections for polar grid
bhawkins
committed
f927cb0
Remove densify option. Can just zero-pad
bhawkins
committed
8f0559a
use time-domain zero-padding for fast forward FT
bhawkins
committed
fd3a282

Commits on May 1, 2025

separate polar grid setup from backprojection
bhawkins
committed
8980fd5
fix output from Python bindings
bhawkins
committed
c05b222
log message improvements
bhawkins
committed
456bb4e
include PRI in duration and time bounds
bhawkins
committed
a427637
remove description of deleted densify option
bhawkins
committed
2ffd2fc
naming things
bhawkins
committed
de099ff

Commits on May 2, 2025

refactor cuda to match cpp
bhawkins
committed
3288ce1
fix tuple returns and make bbox return indices rather than grid
bhawkins
committed
a739484
update bbox python bindings to return slices
bhawkins
committed
ab4eaad

Commits on May 3, 2025

fix missed header update
bhawkins
committed
4cfaa71
refactor out some duplicated code
bhawkins
committed
966181b
trailing whitespace
bhawkins
committed
ddccceb
safer cast
bhawkins
committed
b23f35e
fix dimension index and variable names
bhawkins
committed
e49583f
check mask shape
bhawkins
committed
0633b27

Commits on May 5, 2025

avoid std::vector<bool> avoid numpy copies
bhawkins
committed
8ce577b
avoid using undocumented ArrayX<T> template
bhawkins
committed
43e615f

Commits on May 6, 2025

use GPU for ffbp first stage
bhawkins
committed
c55c044

Commits on May 7, 2025

Split NFFT2d into two classes to reduce storage overhead
bhawkins
committed
7097773
Tabulating NFFT kernel doesn't make much difference in runtime, so ditch it.
bhawkins
committed
ef21f6e
fingers getting tired
bhawkins
committed
647c185
eliminate another data buffer
bhawkins
committed
c110c27
Add GPU NFFTKernel
bhawkins
committed
0a65fc4
Refactor GPU NFFT2d to use less memory
bhawkins
committed
577c8c5

Commits on May 8, 2025

Commits on May 9, 2025

copy/paste final stage into CUDA (was already there as a comment--oops)
bhawkins
committed
7298bdb

Commits on May 12, 2025

Do rdr2geo on GPU
bhawkins
committed
8e3aca4
do geo2rdr on GPU
bhawkins
committed
91b47f1
Python bindings for GPU FBP final stage.
bhawkins
committed
4ac3e3f

Commits on May 13, 2025

Fix allocation bug in NFFT2dResult CUDA copy ctor
bhawkins
committed
163de24
Do interpolation on GPU
bhawkins
committed
ab57046
fix GPU phase precision :-O
bhawkins
committed
e4a62e5
omg fix another bug on the same line
bhawkins
committed
49e14ef
parallel stats
bhawkins
committed
2914d34

Commits on May 15, 2025

Commits on May 16, 2025

better syntax for pybind11 equal
bhawkins
committed
77029ba
leave some breadcrumbs about assumptions
bhawkins
committed
dff5c09

Commits on May 17, 2025

major surgery: Use templates and iterators to avoid copying NFFT2dResult objects in Python bindings.
bhawkins
committed
ff171c7

Commits on May 18, 2025

Do NFFT2d on GPU
bhawkins
committed
caec554

Commits on May 19, 2025

failed to remove a copy, but clead up code a bit
bhawkins
committed
3516715

Commits on May 20, 2025

add subsetting for PolarGrid objects
bhawkins
committed
577a9b4

Commits on May 21, 2025

Fix off-by-one error and check assumption in gpu NFFT2d
bhawkins
committed
50a5dde
add helper for basebanding
bhawkins
committed
0fb44d8
Implement middle stage on GPU
bhawkins
committed
4d99b7b

Commits on May 22, 2025

only write FBP sub-images to file if it will persist
bhawkins
committed
18f8a65
Merge branch 'develop' into factorized_bp
bhawkins
committed
53ccf86
Merge branch 'develop' into factorized_bp
bhawkins
committed
42d9d96

Commits on May 28, 2025

fix typo in comment
bhawkins
committed
5317c8d

Commits on Jun 3, 2025

Implement dry tropo correction in final stage.
bhawkins
committed
b121ce0

Commits on Jun 6, 2025

Implement CPI mask in CUDA
bhawkins
committed
0727717
Enable OpenMP for CUDA code
bhawkins
committed
3c9da78

Commits on Jun 21, 2025

Merge branch 'develop' into factorized_bp
bhawkins
committed
1c591a1

Commits on Jun 26, 2025

Merge branch 'develop' into factorized_bp
bhawkins
committed
7fce6ea

Commits on Mar 11, 2026

Merge branch 'develop' into factorized_bp
bhawkins
committed
7c0d973
change exception to warning
bhawkins
committed
f85165d
Explicitly calculate the necessary cache size.
bhawkins
committed
67d6a8f

Commits on Apr 6, 2026

Merge branch 'develop' into factorized_bp
bhawkins
committed
2fe3bf1

Commits on May 8, 2026

Merge branch 'develop' into factorized_bp
bhawkins
committed
f5a1415

Commits on May 19, 2026

Commits on May 21, 2026

Merge branch 'develop' into factorized_bp
bhawkins
committed
f907a79

Commits on May 29, 2026

Merge branch 'develop' into factorized_bp
bhawkins
committed
95f11ab

Commits on Jun 18, 2026

Merge branch 'develop' into factorized_bp
bhawkins
committed
9053800

Commits on Jun 30, 2026

Merge remote-tracking branch 'origin/develop' into factorized_bp
bhawkins
committed
da6fc56

Commits on Jul 1, 2026

Use .cu extension for NFFT2d Python bindings so that thrust compiles.
bhawkins
committed
7ce059b

Commits on Jul 23, 2026

Add Linspace method to return interval edges.
bhawkins
committed
590eecb
Add Linspace::edges unit test
bhawkins
committed
16a9930
Change Linspace::edges to return std::array instead of std::pair.

bhawkins
and
claude
committed
9c3f822
Rename Linspace::edges to Linspace::bounds.

bhawkins
and
claude
committed
b15d901
Account for grid extents when merging them (e.g., extra half pixels).
bhawkins
committed
2c27c56
Fix silly bug in previous commit.
bhawkins
committed
f1d725d
Add bounds read-only property to Linspace bindings
bhawkins
committed
1518bf7
Add Doxygen docs to PolarGrid struct members in Backproject.h
bhawkins
committed
0a12b4f
Add Doxygen docs to backprojectToPolarGrid function declaration
bhawkins
committed
1ba32d7
Add Doxygen docs to accumulatePolarImagesToRadarGrid function
bhawkins
committed
cc58a02
Add Doxygen docs to setupPolarGridForPulses function
bhawkins
committed
bd19d55
Add Doxygen docs to mergePolarImages function
bhawkins
committed
33d471c
Add Doxygen docs to makeSubApertureMask function
bhawkins
committed
416280a
Improve Doxygen docs for accumulatePolarImageToGeoPoints
bhawkins
committed
682ebd1
Improve Doxygen docs for findPolarGridBoundingBoxInRadarCoord
bhawkins
committed
6b1b446
Add Doxygen docs to findPolarGridBoundingBoxInRadarGrid function
bhawkins
committed
c315e74
Add Doxygen docs to computeRadarGridGeoPoints overloads
bhawkins
committed
3f6ec5b
Remove WIP comment
bhawkins
committed
efecae0

Commits on Jul 24, 2026

Commits on Jul 30, 2026

Add Doxygen documentation to NFFTKernel in cuda/core/Kernels.h

bhawkins
and
claude
committed
b475227
Add docs to CUDA NFFT2d header
bhawkins
committed
53e31a3
Rename ffbp -> fbp
bhawkins
committed
c9d08b8
Add docstrings to azcomp_bp and azcomp_fbp functions in focus.py

bhawkins
and
claude
committed
d65a201
Refactor azcomp_bp and azcomp_fbp into separate backprojection module

bhawkins
and
claude
committed
d677ba0
Add docstrings to is_overlapping and Task in backprojection module

bhawkins
and
claude
committed
fa39c22
Fix blocking pre-PR issues in FBP branch

bhawkins
and
claude
committed
45d3ae8
Fix non-existent error code.
bhawkins
committed
a00b2b2
Rename backprojection.py to azcomp_bp.py

bhawkins
and
claude
committed
b356bd9
add module import
bhawkins
committed
ee2cf31
Add standalone unit test for FBP
bhawkins
committed
db92e5d

Commits on Jul 31, 2026

Add more Python bindings for NFFT2d
bhawkins
committed
58f5ce0
Error out for odd NFFT2d sizes
bhawkins
committed
43a8ffe
Actually need to support odd sizes
bhawkins
committed
491099a
Oops, remove error for odd sizes
bhawkins
committed
89f57cc
Fix typo
bhawkins
committed
4dc4bae
Rename log unit
bhawkins
committed
0b264dc
Fix ob1 error that might cause unnecessary copies in GPU interp2d
bhawkins
committed
02dddaf
Same ob1 and modulo fixes for CPU.
bhawkins
committed
5dec872
Expose periodic boundary condition option to python interp1d bindings.
bhawkins
committed
bbab19b
ob1 and modulo fix for interp1d
bhawkins
committed
955b74b
Fix modulo mixing signed/unsigned operands.
bhawkins
committed
a5648bc
Improve NFFT2d unit test.
bhawkins
committed
94d7cc5
Add unit test for NFFT2d python bindings
bhawkins
committed
fa32289
Check for degenerate n=0 case
bhawkins
committed
77a2130
Revert "allow empty radar grids"
bhawkins
committed
e1aca05
Fix a log message
bhawkins
committed
5e3f235

Commits on Aug 3, 2026

Enable CUDA separable compilation for Python bindings
bhawkins
committed
733479f

Commits on Aug 4, 2026

Fix CUDA 13 kernel visibility for pybind linkage

bhawkins
and
claude
committed
5ca283a

Commits on Aug 5, 2026

Use a concrete type for image interpolators to avoid CUDA linking issues.
bhawkins
committed
03d5d84

Commits on Aug 6, 2026

Remove deleted .icc file from install list.
bhawkins
committed
4482f4f
Remove a template parameter I missed.
bhawkins
committed
8342922
Fix dependent name template parsing ambiguity.
bhawkins
committed
c77ee85
Revert "Fix CUDA 13 kernel visibility for pybind linkage"
bhawkins
committed
55995b2
Revert "Enable CUDA separable compilation for Python bindings"
bhawkins
committed
f71a8c9
Remove dead code
bhawkins
committed
4136388
Remove now-unnecessary helper class.
bhawkins
committed
e99e9f5
Harmonize CPU and GPU backprojection APIs.

bhawkins
and
claude
committed
3ee5684

Commits on Aug 7, 2026

Commits on Aug 13, 2026

Merge branch 'develop' into factorized_bp
bhawkins
committed
e614079

Commits on Aug 18, 2026

Merge branch 'develop' into factorized_bp
bhawkins
committed
15754b9

Commits on Aug 25, 2026

Merge branch 'develop' into factorized_bp
bhawkins
committed
306519f

Commits on Aug 26, 2026

Commits on Sep 2, 2026

Default to new FBP algorithm
bhawkins
committed
08b0028
Merge remote-tracking branch 'origin/develop' into factorized_bp
bhawkins
committed
86038eb

Commits on Sep 8, 2026

Merge remote-tracking branch 'origin/develop' into factorized_bp
bhawkins
committed
c5dca45

Commits on Sep 10, 2026

Fix use-after-free risk on interpolator objects during GIL release

bhawkins
and
claude
committed
18a5090
Release GIL around mergePolarImages call

bhawkins
and
claude
committed
fbb1114