Remove jobs for istio/enhancements repo - #5986
Open
jewertow wants to merge 3 commits into
Open
Conversation
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
istio-testing
added
the
size/L
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
Contributor
|
I agree that we should remove the job at least until we have a proper fix or solution to the real issue described in the issue linked. If we create or reopen an issue to onboard the addition again of the job I'm ok for removing the job, at the end we have being having the job failing for over two years |
Member
Author
|
Hey @howardjohn, do you remember why you removed schema-validator if it's still used by istio/enhancements? |
istio-testing
added
the
needs-rebase
Collaborator
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validate-features_enhancements_release-* job fails since 1.19, because tools/schema-validator and validate_schema.sh were removed intentionally in these PRs: istio/tools#2533, #4830. PRs to istio/enhancements were approved regardless of the validate-features job failures, so I do not see any sense in keeping this job in prow config.