AWS: migrate main repos - #6008
Merged
Merged
Conversation
istio-testing
added
size/M
Stevenjin8
force-pushed
the
aws/migrate-main-repos
branch
from
August 18, 2026 14:57
70cb668 to
db31209
Compare
Contributor
Author
|
cc @keithmattix I'm shooting to get an approval by friday morning |
keithmattix
approved these changes
Aug 19, 2026
istio-testing
added
the
needs-rebase
Stevenjin8
force-pushed
the
aws/migrate-main-repos
branch
from
August 20, 2026 14:11
317b1d6 to
85b0e6b
Compare
istio-testing
added
needs-rebase
Stevenjin8
force-pushed
the
aws/migrate-main-repos
branch
from
September 1, 2026 16:30
85b0e6b to
5c363bc
Compare
istio-testing
removed
the
needs-rebase
Stevenjin8
commented
Sep 1, 2026
| - istio/common-files | ||
| - istio/community | ||
| - istio/enhancements | ||
| - istio/istio |
Contributor
Author
There was a problem hiding this comment.
Move do not merge protections to aws
Stevenjin8
commented
Sep 1, 2026
| - istio/common-files | ||
| - istio/community | ||
| - istio/enhancements | ||
| - istio/istio |
Contributor
Author
There was a problem hiding this comment.
have auto merge come from aws
Stevenjin8
commented
Sep 1, 2026
| - istio/client-go | ||
| - istio/common-files | ||
| - istio/enhancements | ||
| - istio/istio |
Contributor
Author
There was a problem hiding this comment.
I should not have removed this, gcp still need to watch this, other than the aws/explicitly excluded branches
Stevenjin8
commented
Sep 1, 2026
Comment on lines
+55
to
+70
| max_size = 60 | ||
| desired_size = 1 | ||
| block_device_mappings = { | ||
| root = { | ||
| device_name = "/dev/xvda" | ||
| ebs = merge(local.gp3_root_volume, { volume_size = 256 }) | ||
| } | ||
| } | ||
| labels = { testing = "test-pool" } | ||
| } | ||
| test2 = { | ||
| ami_type = "AL2023_x86_64_STANDARD" | ||
| instance_types = ["m7a.4xlarge", "m6a.4xlarge", "m7i.4xlarge", "m6i.4xlarge"] | ||
| capacity_type = "SPOT" | ||
| min_size = 1 | ||
| max_size = 30 |
Contributor
Author
There was a problem hiding this comment.
I requested an increase in our ON_DEMAND capacity. But we're going to have to do with spot instances for now.
Stevenjin8
commented
Sep 1, 2026
| } | ||
| "prowjob-build-tools" = { | ||
| read = ["github_istio-testing_pusher"] | ||
| read = ["github_istio-testing_pusher", "testing_ghcr_istio"] |
Contributor
Author
There was a problem hiding this comment.
to push to ghcr.io/istio/
Stevenjin8
commented
Sep 1, 2026
Comment on lines
-16
to
+17
| testing = "gcr.io/istio-testing" | ||
| prerelease-testing = "gcr.io/istio-prerelease-testing" | ||
| testing = "ghcr.io/istio/testing" | ||
| prerelease-testing = "ghcr.io/istio/prerelease-testing" |
Contributor
Author
There was a problem hiding this comment.
I have yet to apply this.
Contributor
There was a problem hiding this comment.
Why the change in format? Do I need to private/delete the ones with the other format?
Contributor
Author
There was a problem hiding this comment.
It's not a change in format. We're going from gcr-> ghcr
keithmattix
approved these changes
Sep 1, 2026
Collaborator
|
@Stevenjin8: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Collaborator
|
@Stevenjin8: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dgn
added a commit
to dgn/istio-test-infra
that referenced
this pull request
Sep 4, 2026
Chart and image both push to ghcr.io/istio/testing/ztunnel:<tag>, so whichever runs last wins the tag. Point Helm chart publishing at a /charts subpath instead. Seems to have been a typo in istio#6008.
istio-testing
pushed a commit
that referenced
this pull request
Sep 4, 2026
Chart and image both push to ghcr.io/istio/testing/ztunnel:<tag>, so whichever runs last wins the tag. Point Helm chart publishing at a /charts subpath instead. Seems to have been a typo in #6008.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this is a big change, I'm going to wait for this pr to be approved, apply the changes, fix the things i inevitably miss, and once everything seems good, will request another review and merge.