Feature/sources diffusion pfr - #18
Open
quietF wants to merge 10 commits into
Open
Conversation
…ections due an allocation of rhs_vec%val without checking for pre-existing assignement.
N-Schwarz
reviewed
Aug 18, 2026
…fusion-pfr' into feature/sources-diffusion-pfr
quietF
marked this pull request as ready for review
August 18, 2026 12:48
N-Schwarz
approved these changes
Aug 20, 2026
Collaborator
Author
|
@szmate00 can you please take a look and approve if you're happy with it? |
Collaborator
|
Hi @szmate00, can you have a look at this pull request, when you have time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Option to have additional diffusion/source in the private flux region. This is a common approach used in codes like SOLPS-ITER to independently match the diffusion downstream and upstream.