Allow discussion to start during cleanup phase#8
Merged
its-everdred merged 2 commits intoMar 15, 2026
Merged
Conversation
- Modified hasNomineeInProgress() to only check for DISCUSSION and VOTE states - CLEANUP state no longer blocks new discussions from starting - Enables overlapping nomination cycles (discussion can start on Monday even if previous nominee is in cleanup) - Prevents nominations from staggering to every other week when back-to-back
- Updated existing test to match new behavior (DISCUSSION, VOTE only) - Added test case verifying CLEANUP doesn't block new discussions
its-everdred
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When nominations run back-to-back, the 8-day cycle (2d discussion + 5d vote + 1d cleanup) pushes past the next Monday, causing nominations to stagger to every other week instead of running weekly.
Solution
Modified
hasNomineeInProgress()to exclude the CLEANUP state from blocking new discussions. Now:Changes
apps/bot/src/lib/nomineeService.ts:hasNomineeInProgress()now only checks forDISCUSSIONandVOTEstatesImpact
Enables weekly nomination cycles when there's a queue, preventing artificial delays caused by the cleanup phase.