Skip to content

Fix: Skip posting vote results when poll data cannot be read #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
its-applekid wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Skip posting vote results when poll data cannot be read #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 6 additions & 22 deletions apps/bot/src/lib/jobScheduler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,28 +513,12 @@ export class NominationJobScheduler implements JobScheduler {
);
});
} else {
// Vote period expired without results - create default failed results
const expiredResults: VoteResults = {
passed: false,
yesVotes: 0,
noVotes: 0,
totalVotes: 0,
quorumMet: false,
passThresholdMet: false,
memberCount: 0,
requiredQuorum: 0,
requiredPassVotes: 0,
};

// Post expired results to all channels
this.voteResultService
.postVoteResults(nominee, expiredResults)
.catch((error) => {
logger.error(
{ error, nomineeId: nominee.id },
'Failed to post expired vote results'
);
});
// Vote period expired without readable poll data - skip posting results
// (Don't post confusing all-zero results when poll data is unavailable)
logger.warn(
{ nomineeId: nominee.id, nomineeName: nominee.name },
'Vote period expired but poll results could not be read - skipping results post'
);
}
} else {
logger.error(
Expand Down
Loading