Skip to content

Reduce object allocations in SpotLightShadowRenderer #2515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
capdevon wants to merge 8 commits into
base: master
Choose a base branch
from
+9 −9
Open

Reduce object allocations in SpotLightShadowRenderer #2515

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2d0de1b
Update SpotLightShadowRenderer.java
capdevon Jun 23, 2025
7a5f700
SpotLightShadowRenderer: fix javadoc
capdevon Jun 24, 2025
d63a2b8
SpotLightShadowRenderer: fix link
capdevon Jun 24, 2025
88788ea
SpotLightShadowRenderer: revert points cloning
capdevon Jun 24, 2025
0932cb9
SpotLightShadowRenderer: restored original author name
capdevon Jul 10, 2025
2aaff95
revert formatting and docs
riccardobl Jan 13, 2026
ea0e37e
improve clarity
riccardobl Jan 13, 2026
986e9e6
reapply tempVec diff that was reverted by mistake
riccardobl Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions jme3-core/src/main/java/com/jme3/shadow/SpotLightShadowRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2009-2021 jMonkeyEngine
* Copyright (c) 2009-2025 jMonkeyEngine
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
Expand Down Expand Up @@ -66,9 +66,9 @@ public class SpotLightShadowRenderer extends AbstractShadowRenderer {

protected Camera shadowCam;
protected SpotLight light;
protected Vector3f[] points = new Vector3f[8];
//Holding the info for fading shadows in the far distance

protected final Camera[] tempCams = new Camera[1];
protected final Vector3f[] points = new Vector3f[8];
protected final Vector3f tempVec = new Vector3f();

/**
* Used for serialization use SpotLightShadowRenderer#SpotLightShadowRenderer(AssetManager assetManager, int shadowMapSize)
Expand Down Expand Up @@ -101,7 +101,8 @@ private void init(int shadowMapSize) {
protected void initFrustumCam() {
Camera viewCam = viewPort.getCamera();
frustumCam = viewCam.clone();
frustumCam.setFrustum(viewCam.getFrustumNear(), zFarOverride, viewCam.getFrustumLeft(), viewCam.getFrustumRight(), viewCam.getFrustumTop(), viewCam.getFrustumBottom());
frustumCam.setFrustum(viewCam.getFrustumNear(), zFarOverride, viewCam.getFrustumLeft(),
viewCam.getFrustumRight(), viewCam.getFrustumTop(), viewCam.getFrustumBottom());
}

/**
Expand Down Expand Up @@ -141,7 +142,7 @@ protected void updateShadowCams(Camera viewCam) {
//shadowCam.setDirection(direction);

shadowCam.setFrustumPerspective(light.getSpotOuterAngle() * FastMath.RAD_TO_DEG * 2.0f, 1, 1f, light.getSpotRange());
shadowCam.getRotation().lookAt(light.getDirection(), shadowCam.getUp());
shadowCam.getRotation().lookAt(light.getDirection(), shadowCam.getUp(tempVec));
shadowCam.setLocation(light.getPosition());

shadowCam.update();
Expand All @@ -159,10 +160,9 @@ protected GeometryList getOccludersToRender(int shadowMapIndex, GeometryList sha
@Override
protected void getReceivers(GeometryList lightReceivers) {
lightReceivers.clear();
Camera[] cameras = new Camera[1];
cameras[0] = shadowCam;
tempCams[0] = shadowCam;
for (Spatial scene : viewPort.getScenes()) {
ShadowUtil.getLitGeometriesInViewPort(scene, viewPort.getCamera(), cameras, RenderQueue.ShadowMode.Receive, lightReceivers);
ShadowUtil.getLitGeometriesInViewPort(scene, viewPort.getCamera(), tempCams, RenderQueue.ShadowMode.Receive, lightReceivers);
}
}

Expand Down