Repository navigation
[B-028] Persist a sidecar incident's parent identity across restarts - #166
Merged
Merged
Conversation
…0.3.0 migrates on first start
Owner
Author
|
Verified by claude-opus-5-5: plan followed. (Independent: the implementer was claude-sonnet-5-5.)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #142
Packet: B-028 · Items: E-005 · Tier: complex · Implemented by: claude-sonnet-5-5
Version impact: minor
Acceptance
go vet ./... && go test -race -count=1 ./...— passesFailing-first test
TestParentChangeAfterARestartOpensANewIncident: failed before (with only theIncidentRecord.Parentfield added, not wired) witha new parent is repaired at once, not held by the cooldown of the repair before: {Act: ... RecheckAt: ...}(the restored incident had no parent, so the change was not seen); passes now. Store: the round trip (Parentadded tosampleKey) andTestSchemaFourDatabaseIsMigratedToTheIncidentParent.Deviations from the packet
ALTER TABLE incidents ADD COLUMN parent;migrateno longer returns at the schema-4 step.parentcolumn when they fake an old database (they resetuser_versionon a fresh one).docs/running.mdtext now says schema 5.docs/upgrading.md's schema table (outsidefiles) still lacks a row for schema 5; not edited per the scope rule. Follow-up needed.