fix(mcptools): always emit mcp.method.name attribute on MCP tracing spans - #9749
Open
Aryanbhargava18 wants to merge 2 commits into
Open
Aryanbhargava18 wants to merge 2 commits into
Aryanbhargava18 wants to merge 2 commits into
Conversation
…pans Signed-off-by: Aryan Bhargava <aryanbhargava644@gmail.com>
…pans Signed-off-by: Aryan Bhargava <aryanbhargava644@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #9748
In
cmd/jaeger/internal/extension/jaegerquery/internal/mcptools/middleware.go,otelsemconv.McpMethodName(method)was previously only appended inside theelseblock whentoolName == "". As a result, tool execution requests (tools/call) recordedgen_ai.operation.nameandgen_ai.tool.name, but omittedmcp.method.name.Per the OpenTelemetry GenAI Semantic Conventions for MCP server spans,
mcp.method.nameis marked asRequiredon all MCP spans (includingtools/call). Furthermore, the specification explicitly notes:This also aligns the tracing middleware with
TestMetricsMiddlewareToolCallSuccessin the same package, which already asserts bothgen_ai.tool.nameandmcp.method.name.Description of the changes
attrswithotelsemconv.McpMethodName(method)increateTracingMiddlewareso it is unconditionally recorded on all MCP spans.TestTracingMiddlewareToolCallSuccessinmiddleware_test.goto assert the presence ofmcp.method.name.How was this change tested?
cmd/jaeger/internal/extension/jaegerquery/internal/mcptools/middleware_test.go.